nastra commented on code in PR #10027:
URL: https://github.com/apache/iceberg/pull/10027#discussion_r1537367647
##########
core/src/test/java/org/apache/iceberg/TestRemoveSnapshots.java:
##########
@@ -202,39 +182,32 @@ public void
testExpireOlderThanWithDeleteInMergedManifests() {
removeSnapshots(table).expireOlderThan(tAfterCommits).deleteWith(deletedFiles::add).commit();
- Assert.assertEquals(
- "Expire should not change current snapshot",
- snapshotId,
- table.currentSnapshot().snapshotId());
- Assert.assertNull(
- "Expire should remove the oldest snapshot",
table.snapshot(firstSnapshot.snapshotId()));
- Assert.assertNull(
- "Expire should remove the second oldest snapshot",
- table.snapshot(secondSnapshot.snapshotId()));
-
- Assert.assertEquals(
- "Should remove expired manifest lists and deleted data file",
- Sets.newHashSet(
- firstSnapshot.manifestListLocation(), // snapshot expired
- firstSnapshot
- .allManifests(table.io())
- .get(0)
- .path(), // manifest was rewritten for delete
- secondSnapshot.manifestListLocation(), // snapshot expired
- FILE_A.path()), // deleted
- deletedFiles);
+ assertThat(table.currentSnapshot().snapshotId()).isEqualTo(snapshotId);
+ assertThat(table.snapshot(firstSnapshot.snapshotId())).isNull();
+ assertThat(table.snapshot(secondSnapshot.snapshotId())).isNull();
+
+ assertThat(deletedFiles)
+ .as("Should remove expired manifest lists and deleted data file")
+ .isEqualTo(
+ Sets.newHashSet(
+ firstSnapshot.manifestListLocation(), // snapshot expired
+ firstSnapshot
+ .allManifests(table.io())
+ .get(0)
+ .path(), // manifest was rewritten for delete
+ secondSnapshot.manifestListLocation(), // snapshot expired
+ FILE_A.path()));
Review Comment:
original comment is missing here: `// deleted`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
