Re: [PR] Migrate Read in Core to JUnit5 [iceberg]

nastra merged PR #9849: URL: https://github.com/apache/iceberg/pull/9849 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Migrate Read in Core to JUnit5 [iceberg]

tomtongue commented on PR #9849: URL: https://github.com/apache/iceberg/pull/9849#issuecomment-1982188699 @nastra Thank you! Reflected the minor comment. If there's any part that I should change, please let me know. -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] Migrate Read in Core to JUnit5 [iceberg]

nastra commented on code in PR #9849: URL: https://github.com/apache/iceberg/pull/9849#discussion_r1514880737 ## core/src/test/java/org/apache/iceberg/TestFindFiles.java: ## @@ -184,33 +181,33 @@ public void testCaseSensitivity() { .withMetadataMatching(Expressions.

Re: [PR] Migrate Read in Core to JUnit5 [iceberg]

tomtongue commented on PR #9849: URL: https://github.com/apache/iceberg/pull/9849#issuecomment-1981376570 @nastra Update with your comments. When you have time, could you review the new commit? -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Migrate Read in Core to JUnit5 [iceberg]

tomtongue commented on code in PR #9849: URL: https://github.com/apache/iceberg/pull/9849#discussion_r1514762594 ## core/src/test/java/org/apache/iceberg/TestMetadataTableScans.java: ## @@ -1357,27 +1344,27 @@ private void testPositionDeletesBaseTableFilter(boolean transactiona

Re: [PR] Migrate Read in Core to JUnit5 [iceberg]

tomtongue commented on code in PR #9849: URL: https://github.com/apache/iceberg/pull/9849#discussion_r1514762022 ## core/src/test/java/org/apache/iceberg/TestMetadataTableScans.java: ## @@ -1357,27 +1344,27 @@ private void testPositionDeletesBaseTableFilter(boolean transactiona

Re: [PR] Migrate Read in Core to JUnit5 [iceberg]

tomtongue commented on code in PR #9849: URL: https://github.com/apache/iceberg/pull/9849#discussion_r1512208471 ## core/src/test/java/org/apache/iceberg/TestIncrementalDataTableScan.java: ## @@ -196,56 +193,66 @@ public void testRollbacks() { transaction.commitTransaction(

Re: [PR] Migrate Read in Core to JUnit5 [iceberg]

tomtongue commented on code in PR #9849: URL: https://github.com/apache/iceberg/pull/9849#discussion_r1512205833 ## core/src/test/java/org/apache/iceberg/TestBase.java: ## @@ -745,6 +745,12 @@ void assertEquals(String context, Object expected, Object actual) { assertTh

Re: [PR] Migrate Read in Core to JUnit5 [iceberg]

tomtongue commented on code in PR #9849: URL: https://github.com/apache/iceberg/pull/9849#discussion_r1512205470 ## core/src/test/java/org/apache/iceberg/TestBatchScans.java: ## @@ -51,27 +48,27 @@ public void testDataTableScan() { BatchScan scan = table.newBatchScan();

Re: [PR] Migrate Read in Core to JUnit5 [iceberg]

tomtongue commented on code in PR #9849: URL: https://github.com/apache/iceberg/pull/9849#discussion_r1512160426 ## core/src/test/java/org/apache/iceberg/TestMetadataTableScans.java: ## @@ -356,14 +353,14 @@ public void testPartitionsTableScanNoFilter() { Ty

Re: [PR] Migrate Read in Core to JUnit5 [iceberg]

tomtongue commented on code in PR #9849: URL: https://github.com/apache/iceberg/pull/9849#discussion_r1512157166 ## core/src/test/java/org/apache/iceberg/TestIncrementalDataTableScan.java: ## @@ -196,56 +193,66 @@ public void testRollbacks() { transaction.commitTransaction(

Re: [PR] Migrate Read in Core to JUnit5 [iceberg]

tomtongue commented on code in PR #9849: URL: https://github.com/apache/iceberg/pull/9849#discussion_r1512150409 ## core/src/test/java/org/apache/iceberg/TestIncrementalDataTableScan.java: ## @@ -31,49 +35,42 @@ import org.apache.iceberg.relocated.com.google.common.collect.Iter

Re: [PR] Migrate Read in Core to JUnit5 [iceberg]

tomtongue commented on code in PR #9849: URL: https://github.com/apache/iceberg/pull/9849#discussion_r1512141524 ## core/src/test/java/org/apache/iceberg/TestEntriesMetadataTable.java: ## @@ -68,20 +63,19 @@ public void testEntriesTableScan() { Schema expectedSchema =

Re: [PR] Migrate Read in Core to JUnit5 [iceberg]

tomtongue commented on PR #9849: URL: https://github.com/apache/iceberg/pull/9849#issuecomment-1976907122 Thanks for the review. Will reflect on the comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] Migrate Read in Core to JUnit5 [iceberg]

nastra commented on code in PR #9849: URL: https://github.com/apache/iceberg/pull/9849#discussion_r1511226566 ## core/src/test/java/org/apache/iceberg/TestMetadataTableScansWithPartitionEvolution.java: ## @@ -239,15 +234,15 @@ public void testPartitionSpecEvolutionToUnpartitione

Re: [PR] Migrate Read in Core to JUnit5 [iceberg]

nastra commented on code in PR #9849: URL: https://github.com/apache/iceberg/pull/9849#discussion_r1511226028 ## core/src/test/java/org/apache/iceberg/TestMetadataTableScansWithPartitionEvolution.java: ## @@ -193,38 +190,36 @@ public void testPositionDeletesPartitionSpecRemoval(

Re: [PR] Migrate Read in Core to JUnit5 [iceberg]

nastra commented on code in PR #9849: URL: https://github.com/apache/iceberg/pull/9849#discussion_r1511224807 ## core/src/test/java/org/apache/iceberg/TestMetadataTableScans.java: ## @@ -1357,27 +1344,27 @@ private void testPositionDeletesBaseTableFilter(boolean transactional)

Re: [PR] Migrate Read in Core to JUnit5 [iceberg]

nastra commented on code in PR #9849: URL: https://github.com/apache/iceberg/pull/9849#discussion_r1511221874 ## core/src/test/java/org/apache/iceberg/TestMetadataTableScans.java: ## @@ -382,13 +379,13 @@ public void testPartitionsTableScanWithProjection() { .asStru

Re: [PR] Migrate Read in Core to JUnit5 [iceberg]

nastra commented on code in PR #9849: URL: https://github.com/apache/iceberg/pull/9849#discussion_r1511212604 ## core/src/test/java/org/apache/iceberg/TestMetadataTableScans.java: ## @@ -356,14 +353,14 @@ public void testPartitionsTableScanNoFilter() { Types

Re: [PR] Migrate Read in Core to JUnit5 [iceberg]

nastra commented on code in PR #9849: URL: https://github.com/apache/iceberg/pull/9849#discussion_r1511206091 ## core/src/test/java/org/apache/iceberg/TestIncrementalDataTableScan.java: ## @@ -196,56 +193,66 @@ public void testRollbacks() { transaction.commitTransaction();

Re: [PR] Migrate Read in Core to JUnit5 [iceberg]

nastra commented on code in PR #9849: URL: https://github.com/apache/iceberg/pull/9849#discussion_r1511205551 ## core/src/test/java/org/apache/iceberg/TestIncrementalDataTableScan.java: ## @@ -196,56 +193,66 @@ public void testRollbacks() { transaction.commitTransaction();

Re: [PR] Migrate Read in Core to JUnit5 [iceberg]

nastra commented on code in PR #9849: URL: https://github.com/apache/iceberg/pull/9849#discussion_r1511205033 ## core/src/test/java/org/apache/iceberg/TestIncrementalDataTableScan.java: ## @@ -196,56 +193,66 @@ public void testRollbacks() { transaction.commitTransaction();

Re: [PR] Migrate Read in Core to JUnit5 [iceberg]

nastra commented on code in PR #9849: URL: https://github.com/apache/iceberg/pull/9849#discussion_r1511203446 ## core/src/test/java/org/apache/iceberg/TestIncrementalDataTableScan.java: ## @@ -31,49 +35,42 @@ import org.apache.iceberg.relocated.com.google.common.collect.Iterabl

Re: [PR] Migrate Read in Core to JUnit5 [iceberg]

nastra commented on code in PR #9849: URL: https://github.com/apache/iceberg/pull/9849#discussion_r1511201452 ## core/src/test/java/org/apache/iceberg/TestFindFiles.java: ## @@ -18,40 +18,37 @@ */ package org.apache.iceberg; +import static org.assertj.core.api.Assertions.as

Re: [PR] Migrate Read in Core to JUnit5 [iceberg]

nastra commented on code in PR #9849: URL: https://github.com/apache/iceberg/pull/9849#discussion_r1511200542 ## core/src/test/java/org/apache/iceberg/TestEntriesMetadataTable.java: ## @@ -146,22 +140,24 @@ public void testEntriesTableWithDeleteManifests() { Schema expected

Re: [PR] Migrate Read in Core to JUnit5 [iceberg]

nastra commented on code in PR #9849: URL: https://github.com/apache/iceberg/pull/9849#discussion_r1511199403 ## core/src/test/java/org/apache/iceberg/TestEntriesMetadataTable.java: ## @@ -68,20 +63,19 @@ public void testEntriesTableScan() { Schema expectedSchema =

Re: [PR] Migrate Read in Core to JUnit5 [iceberg]

nastra commented on code in PR #9849: URL: https://github.com/apache/iceberg/pull/9849#discussion_r1511196427 ## core/src/test/java/org/apache/iceberg/TestBase.java: ## @@ -745,6 +745,12 @@ void assertEquals(String context, Object expected, Object actual) { assertThat(

Re: [PR] Migrate Read in Core to JUnit5 [iceberg]

nastra commented on code in PR #9849: URL: https://github.com/apache/iceberg/pull/9849#discussion_r1511195274 ## core/src/test/java/org/apache/iceberg/TestBatchScans.java: ## @@ -51,27 +48,27 @@ public void testDataTableScan() { BatchScan scan = table.newBatchScan();

Re: [PR] Migrate Read in Core to JUnit5 [iceberg]

nastra commented on code in PR #9849: URL: https://github.com/apache/iceberg/pull/9849#discussion_r1511191340 ## core/src/test/java/org/apache/iceberg/TestBase.java: ## @@ -745,6 +745,12 @@ void assertEquals(String context, Object expected, Object actual) { assertThat(

Re: [PR] Migrate Read in Core to JUnit5 [iceberg]

nastra commented on code in PR #9849: URL: https://github.com/apache/iceberg/pull/9849#discussion_r1511187801 ## core/src/test/java/org/apache/iceberg/TestBase.java: ## @@ -745,6 +745,12 @@ void assertEquals(String context, Object expected, Object actual) { assertThat(

Re: [PR] Migrate Read in Core to JUnit5 [iceberg]

nastra commented on code in PR #9849: URL: https://github.com/apache/iceberg/pull/9849#discussion_r1511187801 ## core/src/test/java/org/apache/iceberg/TestBase.java: ## @@ -745,6 +745,12 @@ void assertEquals(String context, Object expected, Object actual) { assertThat(

Re: [PR] Migrate Read in Core to JUnit5 [iceberg]

nastra commented on code in PR #9849: URL: https://github.com/apache/iceberg/pull/9849#discussion_r1511186311 ## core/src/test/java/org/apache/iceberg/MetadataTableScanTestBase.java: ## @@ -89,18 +88,16 @@ protected void validatePartition( CloseableIterable>> entries,

Re: [PR] Migrate Read in Core to JUnit5 [iceberg]

nastra commented on code in PR #9849: URL: https://github.com/apache/iceberg/pull/9849#discussion_r1511185544 ## core/src/test/java/org/apache/iceberg/MetadataTableScanTestBase.java: ## @@ -89,18 +88,16 @@ protected void validatePartition( CloseableIterable>> entries,

Re: [PR] Migrate Read in Core to JUnit5 [iceberg]

tomtongue commented on PR #9849: URL: https://github.com/apache/iceberg/pull/9849#issuecomment-1976599386 @nastra Complete the migration of the above classes. Could you review this when you have time? -- This is an automated message from the Apache Git Service. To respond to the message,