nastra commented on code in PR #9849:
URL: https://github.com/apache/iceberg/pull/9849#discussion_r1511187801
##########
core/src/test/java/org/apache/iceberg/TestBase.java:
##########
@@ -745,6 +745,12 @@ void assertEquals(String context, Object expected, Object
actual) {
assertThat(actual).as(context).isEqualTo(expected);
}
}
+
+ void assertHasSize(String context, int expected, List<?> actualList) {
Review Comment:
I don't think we need this method. It's actually clearer to read the code
when using `assertThat()` directly and this also allows to combine this with
other checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
