nastra commented on code in PR #9849:
URL: https://github.com/apache/iceberg/pull/9849#discussion_r1511195274
##########
core/src/test/java/org/apache/iceberg/TestBatchScans.java:
##########
@@ -51,27 +48,27 @@ public void testDataTableScan() {
BatchScan scan = table.newBatchScan();
List<ScanTask> tasks = planTasks(scan);
- Assert.assertEquals("Expected 2 tasks", 2, tasks.size());
+ assertThat(tasks).hasSize(2);
FileScanTask t1 = tasks.get(0).asFileScanTask();
- Assert.assertEquals("Task file must match", t1.file().path(),
FILE_A.path());
- V1Assert.assertEquals("Task deletes size must match", 0,
t1.deletes().size());
- V2Assert.assertEquals("Task deletes size must match", 1,
t1.deletes().size());
+ assertThat(FILE_A.path()).as("Task file must
match").isEqualTo(t1.file().path());
+ V1Assert.assertHasSize("Task deletes size must match", 0, t1.deletes());
+ V2Assert.assertHasSize("Task deletes size must match", 1, t1.deletes());
Review Comment:
I think changing this should be done separately from migrating away from
JUnit4. That means that we can consider making `TableAssertions` more fluent
and more like AssertJ assertions, but that shouldn't be part of this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
