nastra commented on code in PR #9849:
URL: https://github.com/apache/iceberg/pull/9849#discussion_r1511200542
##########
core/src/test/java/org/apache/iceberg/TestEntriesMetadataTable.java:
##########
@@ -146,22 +140,24 @@ public void testEntriesTableWithDeleteManifests() {
Schema expectedSchema =
TypeUtil.join(readSchema,
MetricsUtil.readableMetricsSchema(table.schema(), readSchema));
- assertEquals(
- "A tableScan.select() should prune the schema",
- expectedSchema.asStruct(),
- scan.schema().asStruct());
+ assertThat(scan.schema().asStruct())
+ .as("A tableScan.select() should prune the schema")
+ .isEqualTo(expectedSchema.asStruct());
List<FileScanTask> files = ImmutableList.copyOf(scan.planFiles());
- Assert.assertEquals(
- "Data file should be the table's manifest",
-
Iterables.getOnlyElement(table.currentSnapshot().dataManifests(table.io())).path(),
- files.get(0).file().path());
- Assert.assertEquals("Should contain 2 data file records", 2,
files.get(0).file().recordCount());
- Assert.assertEquals(
- "Delete file should be in the table manifest",
-
Iterables.getOnlyElement(table.currentSnapshot().deleteManifests(table.io())).path(),
- files.get(1).file().path());
- Assert.assertEquals(
- "Should contain 1 delete file record", 1,
files.get(1).file().recordCount());
+ assertThat(files.get(0).file().path())
+ .as("Data file should be the table's manifest")
+ .isEqualTo(
+
Iterables.getOnlyElement(table.currentSnapshot().dataManifests(table.io())).path());
Review Comment:
same as above (and also applies to all the other places modified in this PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
