wgtmac commented on PR #13:
URL: https://github.com/apache/iceberg-cpp/pull/13#issuecomment-2585760545
@zhjwpku It is better to change the PR title to reflect that we have chosen
googletest?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
wgtmac commented on PR #13:
URL: https://github.com/apache/iceberg-cpp/pull/13#issuecomment-2585760084
@Fokko @Xuanwo Should we merge this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
raulcd commented on code in PR #13:
URL: https://github.com/apache/iceberg-cpp/pull/13#discussion_r1899366861
##
ci/scripts/build_iceberg.sh:
##
@@ -31,6 +31,7 @@ cmake \
-DICEBERG_BUILD_SHARED=ON \
${source_dir}
cmake --build . --target install
+ctest --output-on-fai
zhjwpku commented on PR #13:
URL: https://github.com/apache/iceberg-cpp/pull/13#issuecomment-2563425266
> BTW, should we run ctest in build_iceberg.sh (or a separate script) from
pre-commit check in the CI?
I've added the ctest command in build_iceberg.sh, this will run test on all
p
wgtmac commented on PR #13:
URL: https://github.com/apache/iceberg-cpp/pull/13#issuecomment-2563419029
BTW, should we run ctest in build_iceberg.sh (or a separate script) from
pre-commit check in the CI?
--
This is an automated message from the Apache Git Service.
To respond to the messag
zhjwpku commented on PR #13:
URL: https://github.com/apache/iceberg-cpp/pull/13#issuecomment-2563416726
@raulcd @Fokko can you please review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
zhjwpku commented on code in PR #13:
URL: https://github.com/apache/iceberg-cpp/pull/13#discussion_r1897045482
##
test/CMakeLists.txt:
##
@@ -14,3 +14,7 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
#
wgtmac commented on code in PR #13:
URL: https://github.com/apache/iceberg-cpp/pull/13#discussion_r1896787151
##
README.md:
##
@@ -28,13 +28,14 @@ C++ implementation of [Apache
Iceberg™](https://iceberg.apache.org/).
## Build
-### Build and Install Core Libraries
+### Buil
zhjwpku commented on code in PR #13:
URL: https://github.com/apache/iceberg-cpp/pull/13#discussion_r1896438330
##
cmake_modules/FindGTestAlt.cmake:
##
@@ -0,0 +1,28 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See t
wgtmac commented on code in PR #13:
URL: https://github.com/apache/iceberg-cpp/pull/13#discussion_r1895873224
##
cmake_modules/FindGTestAlt.cmake:
##
@@ -0,0 +1,28 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See th
pitrou commented on PR #13:
URL: https://github.com/apache/iceberg-cpp/pull/13#issuecomment-2545484399
> I found this link:
https://yurigeronimus.medium.com/guide-for-choosing-a-test-framework-for-your-c-project-2a7741b53317
Seems like a lot of fluff with no substance, unfortunately.
zhjwpku commented on PR #13:
URL: https://github.com/apache/iceberg-cpp/pull/13#issuecomment-2545430346
> Thanks for the number @zhjwpku .
>
> > As the results shows, catch2 is better at preprocessed file size and
compile time, but gtest is better when it comes to link time. I don't t
pitrou commented on PR #13:
URL: https://github.com/apache/iceberg-cpp/pull/13#issuecomment-2545345091
Thanks for the number @zhjwpku .
> As the results shows, catch2 is better at preprocessed file size and
compile time, but gtest is better when it comes to link time. I don't think th
zhjwpku commented on PR #13:
URL: https://github.com/apache/iceberg-cpp/pull/13#issuecomment-2545327922
> Thanks @zhjwpku !
>
> What I would be interested to know is the compile and link times,
respectively, for both GTest and Catch2. My experience in Arrow is that GTest's
main heade
pitrou commented on PR #13:
URL: https://github.com/apache/iceberg-cpp/pull/13#issuecomment-2543934115
Thanks @zhjwpku !
What I would be interested to know is the compile and link times,
respectively, for both GTest and Catch2.
My experience in Arrow is that GTest's main header `gt
15 matches
Mail list logo
