wgtmac commented on code in PR #13: URL: https://github.com/apache/iceberg-cpp/pull/13#discussion_r1896787151
########## README.md: ########## @@ -28,13 +28,14 @@ C++ implementation of [Apache Iceberg™](https://iceberg.apache.org/). ## Build -### Build and Install Core Libraries +### Build, Run Test and Install Core Libraries ```bash cd iceberg-cpp mkdir build && cd build cmake .. -DCMAKE_INSTALL_PREFIX=/tmp/iceberg -DICEBERG_BUILD_STATIC=ON -DICEBERG_BUILD_SHARED=ON cmake --build . +ctest --build . Review Comment: Is better to use `ctest --output-on-failure`? ########## test/CMakeLists.txt: ########## @@ -14,3 +14,7 @@ # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. + +include(FindGTestAlt) Review Comment: Do we actually need a separate FindGTestAlt file? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
