zhjwpku commented on code in PR #13: URL: https://github.com/apache/iceberg-cpp/pull/13#discussion_r1897045482
########## test/CMakeLists.txt: ########## @@ -14,3 +14,7 @@ # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. + +include(FindGTestAlt) Review Comment: I have no strong opinion here, I just thought gathering all the thirdparties' cmake file in cmake_modules might be easy to manage. I admit this is a simple one which could be insert directly here, so will change to that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
