nastra merged PR #9353:
URL: https://github.com/apache/iceberg/pull/9353
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac
nastra commented on code in PR #9353:
URL: https://github.com/apache/iceberg/pull/9353#discussion_r1457034301
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##
@@ -482,7 +489,13 @@ public boolean removeProperties(Namespace namespace,
Set properties)
@Overr
huyuanfeng2018 commented on code in PR #9353:
URL: https://github.com/apache/iceberg/pull/9353#discussion_r1456729227
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##
@@ -482,7 +489,13 @@ public boolean removeProperties(Namespace namespace,
Set properties)
nastra commented on code in PR #9353:
URL: https://github.com/apache/iceberg/pull/9353#discussion_r1455378169
##
aws/src/main/java/org/apache/iceberg/aws/dynamodb/DynamoDbCatalog.java:
##
@@ -143,6 +142,7 @@ void initialize(
this.closeableGroup = new CloseableGroup();
nastra commented on code in PR #9353:
URL: https://github.com/apache/iceberg/pull/9353#discussion_r1455363550
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##
@@ -482,7 +489,13 @@ public boolean removeProperties(Namespace namespace,
Set properties)
@Overr
amogh-jahagirdar commented on code in PR #9353:
URL: https://github.com/apache/iceberg/pull/9353#discussion_r1454385050
##
aws/src/main/java/org/apache/iceberg/aws/dynamodb/DynamoDbCatalog.java:
##
@@ -487,6 +486,7 @@ public Configuration getConf() {
@Override
public voi
huyuanfeng2018 commented on code in PR #9353:
URL: https://github.com/apache/iceberg/pull/9353#discussion_r1454364047
##
aws/src/main/java/org/apache/iceberg/aws/dynamodb/DynamoDbCatalog.java:
##
@@ -487,6 +486,7 @@ public Configuration getConf() {
@Override
public void
dramaticlly commented on code in PR #9353:
URL: https://github.com/apache/iceberg/pull/9353#discussion_r1454246356
##
aws/src/main/java/org/apache/iceberg/aws/dynamodb/DynamoDbCatalog.java:
##
@@ -487,6 +486,7 @@ public Configuration getConf() {
@Override
public void clo
huyuanfeng2018 commented on code in PR #9353:
URL: https://github.com/apache/iceberg/pull/9353#discussion_r1448591538
##
aws/src/main/java/org/apache/iceberg/aws/dynamodb/DynamoDbCatalog.java:
##
@@ -487,6 +486,7 @@ public Configuration getConf() {
@Override
public void
huyuanfeng2018 commented on code in PR #9353:
URL: https://github.com/apache/iceberg/pull/9353#discussion_r1440003882
##
aws/src/main/java/org/apache/iceberg/aws/dynamodb/DynamoDbCatalog.java:
##
@@ -487,6 +486,7 @@ public Configuration getConf() {
@Override
public void
dramaticlly commented on code in PR #9353:
URL: https://github.com/apache/iceberg/pull/9353#discussion_r1439989287
##
aws/src/main/java/org/apache/iceberg/aws/dynamodb/DynamoDbCatalog.java:
##
@@ -487,6 +486,7 @@ public Configuration getConf() {
@Override
public void clo
huyuanfeng2018 commented on code in PR #9353:
URL: https://github.com/apache/iceberg/pull/9353#discussion_r1437005760
##
aws/src/main/java/org/apache/iceberg/aws/dynamodb/DynamoDbCatalog.java:
##
@@ -487,6 +486,7 @@ public Configuration getConf() {
@Override
public void
aokolnychyi commented on code in PR #9353:
URL: https://github.com/apache/iceberg/pull/9353#discussion_r1436890848
##
aws/src/main/java/org/apache/iceberg/aws/dynamodb/DynamoDbCatalog.java:
##
@@ -487,6 +486,7 @@ public Configuration getConf() {
@Override
public void clo
huyuanfeng2018 commented on code in PR #9353:
URL: https://github.com/apache/iceberg/pull/9353#discussion_r1433701509
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##
@@ -482,7 +483,14 @@ public boolean removeProperties(Namespace namespace,
Set properties)
nastra commented on code in PR #9353:
URL: https://github.com/apache/iceberg/pull/9353#discussion_r1433669118
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##
@@ -482,7 +483,14 @@ public boolean removeProperties(Namespace namespace,
Set properties)
@Overr
huyuanfeng2018 commented on code in PR #9353:
URL: https://github.com/apache/iceberg/pull/9353#discussion_r1432824971
##
.palantir/revapi.yml:
##
@@ -886,6 +886,13 @@ acceptedBreaks:
- code: "java.field.serialVersionUIDChanged"
new: "field org.apache.iceberg.util.Ser
huyuanfeng2018 commented on code in PR #9353:
URL: https://github.com/apache/iceberg/pull/9353#discussion_r1432764950
##
.palantir/revapi.yml:
##
@@ -886,6 +886,13 @@ acceptedBreaks:
- code: "java.field.serialVersionUIDChanged"
new: "field org.apache.iceberg.util.Ser
huyuanfeng2018 commented on code in PR #9353:
URL: https://github.com/apache/iceberg/pull/9353#discussion_r1432764950
##
.palantir/revapi.yml:
##
@@ -886,6 +886,13 @@ acceptedBreaks:
- code: "java.field.serialVersionUIDChanged"
new: "field org.apache.iceberg.util.Ser
nastra commented on code in PR #9353:
URL: https://github.com/apache/iceberg/pull/9353#discussion_r1432723511
##
.palantir/revapi.yml:
##
@@ -886,6 +886,13 @@ acceptedBreaks:
- code: "java.field.serialVersionUIDChanged"
new: "field org.apache.iceberg.util.Serializabl
huyuanfeng2018 commented on PR #9353:
URL: https://github.com/apache/iceberg/pull/9353#issuecomment-1864424893
cc @nastra
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
20 matches
Mail list logo
