huyuanfeng2018 commented on code in PR #9353: URL: https://github.com/apache/iceberg/pull/9353#discussion_r1432764950
########## .palantir/revapi.yml: ########## @@ -886,6 +886,13 @@ acceptedBreaks: - code: "java.field.serialVersionUIDChanged" new: "field org.apache.iceberg.util.SerializableMap<K, V>.serialVersionUID" justification: "Serialization is not be used" + - code: "java.method.exception.checkedAdded" Review Comment: > we don't want to break existing APIs, so changes to this file need to be reverted It looks like `MetricsReporter` doesn't have to implement `Closeable`, I'll fix it here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org