nastra commented on code in PR #9353:
URL: https://github.com/apache/iceberg/pull/9353#discussion_r1455363550
##########
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##########
@@ -482,7 +489,13 @@ public boolean removeProperties(Namespace namespace,
Set<String> properties)
@Override
public void close() {
- connections.close();
+ if (closeableGroup != null) {
+ try {
Review Comment:
I don't think we need to wrap this in a try-catch block here and none of the
other catalogs do, so I think we can remove this here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
