huyuanfeng2018 commented on code in PR #9353: URL: https://github.com/apache/iceberg/pull/9353#discussion_r1437005760
########## aws/src/main/java/org/apache/iceberg/aws/dynamodb/DynamoDbCatalog.java: ########## @@ -487,6 +486,7 @@ public Configuration getConf() { @Override public void close() throws IOException { + super.close(); Review Comment: I don’t quite understand what problem can be solved by using `closeableGroup` it's here, Can you give some examples? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org