Re: [PR] Bug fix for writing empty df or null only columns [iceberg-python]

Fokko merged PR #350: URL: https://github.com/apache/iceberg-python/pull/350 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [PR] Bug fix for writing empty df or null only columns [iceberg-python]

syun64 commented on code in PR #350: URL: https://github.com/apache/iceberg-python/pull/350#discussion_r1475221887 ## pyiceberg/table/__init__.py: ## @@ -946,10 +946,13 @@ def append(self, df: pa.Table) -> None: if len(self.sort_order().fields) > 0: raise V

Re: [PR] Bug fix for writing empty df or null only columns [iceberg-python]

Fokko commented on code in PR #350: URL: https://github.com/apache/iceberg-python/pull/350#discussion_r1475221574 ## pyiceberg/io/pyarrow.py: ## @@ -1339,7 +1339,10 @@ def update_min(self, val: Any) -> None: def update_max(self, val: Any) -> None: self.current_max

Re: [PR] Bug fix for writing empty df or null only columns [iceberg-python]

Fokko commented on code in PR #350: URL: https://github.com/apache/iceberg-python/pull/350#discussion_r1475221146 ## pyiceberg/table/__init__.py: ## @@ -946,10 +946,13 @@ def append(self, df: pa.Table) -> None: if len(self.sort_order().fields) > 0: raise Va

Re: [PR] Bug fix for writing empty df or null only columns [iceberg-python]

syun64 commented on code in PR #350: URL: https://github.com/apache/iceberg-python/pull/350#discussion_r1475056028 ## pyiceberg/io/pyarrow.py: ## @@ -1339,7 +1339,10 @@ def update_min(self, val: Any) -> None: def update_max(self, val: Any) -> None: self.current_max

Re: [PR] Bug fix for writing empty df or null only columns [iceberg-python]

syun64 commented on code in PR #350: URL: https://github.com/apache/iceberg-python/pull/350#discussion_r1475057957 ## tests/integration/test_writes.py: ## @@ -409,3 +537,53 @@ def test_invalid_arguments(spark: SparkSession, session_catalog: Catalog, arrow_ with pytest.ra

Re: [PR] Bug fix for writing empty df or null only columns [iceberg-python]

syun64 commented on code in PR #350: URL: https://github.com/apache/iceberg-python/pull/350#discussion_r1475056028 ## pyiceberg/io/pyarrow.py: ## @@ -1339,7 +1339,10 @@ def update_min(self, val: Any) -> None: def update_max(self, val: Any) -> None: self.current_max

Re: [PR] Bug fix for writing empty df or null only columns [iceberg-python]

syun64 commented on code in PR #350: URL: https://github.com/apache/iceberg-python/pull/350#discussion_r1475055056 ## tests/integration/test_writes.py: ## @@ -142,6 +142,54 @@ def arrow_table_with_null() -> pa.Table: return pa.Table.from_pydict(TEST_DATA_WITH_NULL, schema=p

Re: [PR] Bug fix for writing empty df or null only columns [iceberg-python]

syun64 commented on code in PR #350: URL: https://github.com/apache/iceberg-python/pull/350#discussion_r1475054618 ## pyiceberg/table/__init__.py: ## @@ -946,10 +946,13 @@ def append(self, df: pa.Table) -> None: if len(self.sort_order().fields) > 0: raise V

Re: [PR] Bug fix for writing empty df or null only columns [iceberg-python]

Fokko commented on code in PR #350: URL: https://github.com/apache/iceberg-python/pull/350#discussion_r1475048933 ## pyiceberg/table/__init__.py: ## @@ -946,10 +946,13 @@ def append(self, df: pa.Table) -> None: if len(self.sort_order().fields) > 0: raise Va

Re: [PR] Bug fix for writing empty df or null only columns [iceberg-python]

jqin61 commented on code in PR #350: URL: https://github.com/apache/iceberg-python/pull/350#discussion_r1475030454 ## tests/integration/test_writes.py: ## @@ -409,3 +537,53 @@ def test_invalid_arguments(spark: SparkSession, session_catalog: Catalog, arrow_ with pytest.ra