syun64 commented on code in PR #350:
URL: https://github.com/apache/iceberg-python/pull/350#discussion_r1475057957
##########
tests/integration/test_writes.py:
##########
@@ -409,3 +537,53 @@ def test_invalid_arguments(spark: SparkSession,
session_catalog: Catalog, arrow_
with pytest.raises(ValueError, match="Expected PyArrow table, got: not a
df"):
tbl.append("not a df")
+
+
[email protected]
+def test_summaries_with_only_nulls(
+ spark: SparkSession, session_catalog: Catalog, arrow_table_without_data:
pa.Table, arrow_table_with_only_nulls: pa.Table
+) -> None:
+ identifier = "default.arrow_table_summaries_with_only_nulls"
+
+ try:
+ session_catalog.drop_table(identifier=identifier)
+ except NoSuchTableError:
+ pass
+ tbl = session_catalog.create_table(identifier=identifier,
schema=TABLE_SCHEMA, properties={'format-version': '1'})
+
+ tbl.append(arrow_table_without_data)
+ tbl.append(arrow_table_with_only_nulls)
Review Comment:
I missed that, thank you! @jqin61
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
