jqin61 commented on code in PR #350: URL: https://github.com/apache/iceberg-python/pull/350#discussion_r1475030454
########## tests/integration/test_writes.py: ########## @@ -409,3 +537,53 @@ def test_invalid_arguments(spark: SparkSession, session_catalog: Catalog, arrow_ with pytest.raises(ValueError, match="Expected PyArrow table, got: not a df"): tbl.append("not a df") + + +@pytest.mark.integration +def test_summaries_with_only_nulls( + spark: SparkSession, session_catalog: Catalog, arrow_table_without_data: pa.Table, arrow_table_with_only_nulls: pa.Table +) -> None: + identifier = "default.arrow_table_summaries_with_only_nulls" + + try: + session_catalog.drop_table(identifier=identifier) + except NoSuchTableError: + pass + tbl = session_catalog.create_table(identifier=identifier, schema=TABLE_SCHEMA, properties={'format-version': '1'}) + + tbl.append(arrow_table_without_data) + tbl.append(arrow_table_with_only_nulls) Review Comment: shall we add an overwrite as well since overwrite also breaks in the issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org