Fokko commented on code in PR #350:
URL: https://github.com/apache/iceberg-python/pull/350#discussion_r1475221146
##########
pyiceberg/table/__init__.py:
##########
@@ -946,10 +946,13 @@ def append(self, df: pa.Table) -> None:
if len(self.sort_order().fields) > 0:
raise ValueError("Cannot write to tables with a sort-order")
- data_files = _dataframe_to_data_files(self, df=df)
merge = _MergingSnapshotProducer(operation=Operation.APPEND,
table=self)
- for data_file in data_files:
- merge.append_data_file(data_file)
+
+ # skip writing data files if the dataframe is empty
Review Comment:
Got it, thanks for checking this 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
