Re: [PR] API, Core: Add UUID API to Table [iceberg]

2023-12-16 Thread via GitHub
amogh-jahagirdar commented on code in PR #8800: URL: https://github.com/apache/iceberg/pull/8800#discussion_r1428863691 ## core/src/main/java/org/apache/iceberg/BaseMetadataTable.java: ## @@ -199,6 +199,11 @@ public Map refs() { return table().refs(); } + @Override +

Re: [PR] API, Core: Add UUID API to Table [iceberg]

2023-12-16 Thread via GitHub
ajantha-bhat commented on code in PR #8800: URL: https://github.com/apache/iceberg/pull/8800#discussion_r1428761950 ## core/src/main/java/org/apache/iceberg/BaseMetadataTable.java: ## @@ -199,6 +199,11 @@ public Map refs() { return table().refs(); } + @Override + pub

Re: [PR] API, Core: Add UUID API to Table [iceberg]

2023-10-30 Thread via GitHub
nastra merged PR #8800: URL: https://github.com/apache/iceberg/pull/8800 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] API, Core: Add UUID API to Table [iceberg]

2023-10-28 Thread via GitHub
amogh-jahagirdar commented on code in PR #8800: URL: https://github.com/apache/iceberg/pull/8800#discussion_r1375331323 ## core/src/main/java/org/apache/iceberg/BaseMetadataTable.java: ## @@ -199,6 +199,11 @@ public Map refs() { return table().refs(); } + @Override +

Re: [PR] API, Core: Add UUID API to Table [iceberg]

2023-10-28 Thread via GitHub
amogh-jahagirdar commented on code in PR #8800: URL: https://github.com/apache/iceberg/pull/8800#discussion_r1375331323 ## core/src/main/java/org/apache/iceberg/BaseMetadataTable.java: ## @@ -199,6 +199,11 @@ public Map refs() { return table().refs(); } + @Override +

Re: [PR] API, Core: Add UUID API to Table [iceberg]

2023-10-28 Thread via GitHub
amogh-jahagirdar commented on code in PR #8800: URL: https://github.com/apache/iceberg/pull/8800#discussion_r1375331323 ## core/src/main/java/org/apache/iceberg/BaseMetadataTable.java: ## @@ -199,6 +199,11 @@ public Map refs() { return table().refs(); } + @Override +

Re: [PR] API, Core: Add UUID API to Table [iceberg]

2023-10-28 Thread via GitHub
rdblue commented on code in PR #8800: URL: https://github.com/apache/iceberg/pull/8800#discussion_r1375313899 ## core/src/main/java/org/apache/iceberg/BaseMetadataTable.java: ## @@ -199,6 +199,11 @@ public Map refs() { return table().refs(); } + @Override + public St

Re: [PR] API, Core: Add UUID API to Table [iceberg]

2023-10-20 Thread via GitHub
rdblue commented on code in PR #8800: URL: https://github.com/apache/iceberg/pull/8800#discussion_r1367540014 ## core/src/main/java/org/apache/iceberg/BaseMetadataTable.java: ## @@ -199,6 +199,11 @@ public Map refs() { return table().refs(); } + @Override + public St

Re: [PR] API, Core: Add UUID API to Table [iceberg]

2023-10-19 Thread via GitHub
amogh-jahagirdar commented on code in PR #8800: URL: https://github.com/apache/iceberg/pull/8800#discussion_r1365617906 ## api/src/main/java/org/apache/iceberg/Table.java: ## @@ -333,6 +333,15 @@ default UpdateStatistics updateStatistics() { */ Map refs(); + /** + *

Re: [PR] API, Core: Add UUID API to Table [iceberg]

2023-10-11 Thread via GitHub
amogh-jahagirdar commented on code in PR #8800: URL: https://github.com/apache/iceberg/pull/8800#discussion_r1355713680 ## api/src/main/java/org/apache/iceberg/Table.java: ## @@ -333,6 +333,15 @@ default UpdateStatistics updateStatistics() { */ Map refs(); + /** + *

Re: [PR] API, Core: Add UUID API to Table [iceberg]

2023-10-11 Thread via GitHub
amogh-jahagirdar commented on code in PR #8800: URL: https://github.com/apache/iceberg/pull/8800#discussion_r1355680042 ## core/src/main/java/org/apache/iceberg/BaseMetadataTable.java: ## @@ -199,6 +199,11 @@ public Map refs() { return table().refs(); } + @Override +

Re: [PR] API, Core: Add UUID API to Table [iceberg]

2023-10-11 Thread via GitHub
amogh-jahagirdar commented on code in PR #8800: URL: https://github.com/apache/iceberg/pull/8800#discussion_r1355680042 ## core/src/main/java/org/apache/iceberg/BaseMetadataTable.java: ## @@ -199,6 +199,11 @@ public Map refs() { return table().refs(); } + @Override +

Re: [PR] API, Core: Add UUID API to Table [iceberg]

2023-10-11 Thread via GitHub
amogh-jahagirdar commented on code in PR #8800: URL: https://github.com/apache/iceberg/pull/8800#discussion_r1355680042 ## core/src/main/java/org/apache/iceberg/BaseMetadataTable.java: ## @@ -199,6 +199,11 @@ public Map refs() { return table().refs(); } + @Override +

Re: [PR] API, Core: Add UUID API to Table [iceberg]

2023-10-11 Thread via GitHub
rdblue commented on code in PR #8800: URL: https://github.com/apache/iceberg/pull/8800#discussion_r1355662817 ## core/src/main/java/org/apache/iceberg/BaseMetadataTable.java: ## @@ -199,6 +199,11 @@ public Map refs() { return table().refs(); } + @Override + public St

Re: [PR] API, Core: Add UUID API to Table [iceberg]

2023-10-11 Thread via GitHub
rdblue commented on code in PR #8800: URL: https://github.com/apache/iceberg/pull/8800#discussion_r1355661550 ## api/src/main/java/org/apache/iceberg/Table.java: ## @@ -333,6 +333,15 @@ default UpdateStatistics updateStatistics() { */ Map refs(); + /** + * Returns th

Re: [PR] API, Core: Add UUID API to Table [iceberg]

2023-10-11 Thread via GitHub
amogh-jahagirdar commented on code in PR #8800: URL: https://github.com/apache/iceberg/pull/8800#discussion_r1355360614 ## api/src/main/java/org/apache/iceberg/Table.java: ## @@ -333,6 +333,15 @@ default UpdateStatistics updateStatistics() { */ Map refs(); + /** + *

Re: [PR] API, Core: Add UUID API to Table [iceberg]

2023-10-11 Thread via GitHub
jbonofre commented on code in PR #8800: URL: https://github.com/apache/iceberg/pull/8800#discussion_r1355122364 ## core/src/main/java/org/apache/iceberg/BaseTransaction.java: ## @@ -770,6 +770,11 @@ public Map refs() { return current.refs(); } +@Override +p

Re: [PR] API, Core: Add UUID API to Table [iceberg]

2023-10-11 Thread via GitHub
jbonofre commented on code in PR #8800: URL: https://github.com/apache/iceberg/pull/8800#discussion_r1355115550 ## api/src/main/java/org/apache/iceberg/Table.java: ## @@ -333,6 +333,15 @@ default UpdateStatistics updateStatistics() { */ Map refs(); + /** + * Returns

Re: [PR] API, Core: Add UUID API to Table [iceberg]

2023-10-11 Thread via GitHub
RussellSpitzer commented on code in PR #8800: URL: https://github.com/apache/iceberg/pull/8800#discussion_r1355114035 ## api/src/main/java/org/apache/iceberg/Table.java: ## @@ -333,6 +333,15 @@ default UpdateStatistics updateStatistics() { */ Map refs(); + /** + * Re

Re: [PR] API, Core: Add UUID API to Table [iceberg]

2023-10-11 Thread via GitHub
RussellSpitzer commented on code in PR #8800: URL: https://github.com/apache/iceberg/pull/8800#discussion_r1355112214 ## api/src/main/java/org/apache/iceberg/Table.java: ## @@ -333,6 +333,15 @@ default UpdateStatistics updateStatistics() { */ Map refs(); + /** + * Re

Re: [PR] API, Core: Add UUID API to Table [iceberg]

2023-10-11 Thread via GitHub
amogh-jahagirdar commented on PR #8800: URL: https://github.com/apache/iceberg/pull/8800#issuecomment-1757821683 > this LGTM, but I think there should be a check in CatalogTests#testCompleteCreateTable() that makes sure the UUID on the table is set Sure thing, I can add a test for th

Re: [PR] API, Core: Add UUID API to Table [iceberg]

2023-10-11 Thread via GitHub
amogh-jahagirdar commented on code in PR #8800: URL: https://github.com/apache/iceberg/pull/8800#discussion_r1355106715 ## core/src/main/java/org/apache/iceberg/BaseTransaction.java: ## @@ -770,6 +770,11 @@ public Map refs() { return current.refs(); } +@Overrid

Re: [PR] API, Core: Add UUID API to Table [iceberg]

2023-10-11 Thread via GitHub
jbonofre commented on code in PR #8800: URL: https://github.com/apache/iceberg/pull/8800#discussion_r1355045037 ## core/src/main/java/org/apache/iceberg/BaseTransaction.java: ## @@ -770,6 +770,11 @@ public Map refs() { return current.refs(); } +@Override +p

Re: [PR] API, Core: Add UUID API to Table [iceberg]

2023-10-11 Thread via GitHub
nastra commented on code in PR #8800: URL: https://github.com/apache/iceberg/pull/8800#discussion_r1354909112 ## core/src/main/java/org/apache/iceberg/BaseTransaction.java: ## @@ -770,6 +770,11 @@ public Map refs() { return current.refs(); } +@Override +pub

Re: [PR] API, Core: Add UUID API to Table [iceberg]

2023-10-11 Thread via GitHub
amogh-jahagirdar commented on code in PR #8800: URL: https://github.com/apache/iceberg/pull/8800#discussion_r1354731348 ## api/src/main/java/org/apache/iceberg/Table.java: ## @@ -333,6 +333,15 @@ default UpdateStatistics updateStatistics() { */ Map refs(); + /** + *