amogh-jahagirdar commented on code in PR #8800:
URL: https://github.com/apache/iceberg/pull/8800#discussion_r1355680042
##########
core/src/main/java/org/apache/iceberg/BaseMetadataTable.java:
##########
@@ -199,6 +199,11 @@ public Map<String, SnapshotRef> refs() {
return table().refs();
}
+ @Override
+ public String uuid() {
+ return table().uuid();
Review Comment:
I think it is correct, the metadata table is a read only view of certain
aspects of a table and ultimately will wrap a `DataTable` . So I think
surfacing the underlying table's UUID is the right thing to do since a metadata
table won't ever have a UUID itself right?
Alternatively, we could say since UUIDs aren't even defined for metadata
tables and throw an unsupported exception.
If we do that, we may want to revisit the refs() behavior since that
surfaces the underlying table's refs; to be consistent across the APIs we would
probably want to throw there as well (although that's a behavior change).
But in the end I thought since UUIDs are defined in the spec specifically
for Data tables and metadata tables are a logical construct, the metadata
tables should surface the underlying data table's UUID.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
