amogh-jahagirdar commented on code in PR #8800:
URL: https://github.com/apache/iceberg/pull/8800#discussion_r1354731348
##########
api/src/main/java/org/apache/iceberg/Table.java:
##########
@@ -333,6 +333,15 @@ default UpdateStatistics updateStatistics() {
*/
Map<String, SnapshotRef> refs();
+ /**
+ * Returns the UUID of the table
+ *
+ * @return the UUID of the table
+ */
+ default String uuid() {
+ throw new UnsupportedOperationException(this.getClass().getName() + "
doesn't implement uuid");
Review Comment:
This was done to avoid breaking API changes. I don't expect users to
override `Table` due to the presence of core implementations and if they do,
and want to use `UUID` they should implement that.
##########
core/src/main/java/org/apache/iceberg/BaseTransaction.java:
##########
@@ -770,6 +770,11 @@ public Map<String, SnapshotRef> refs() {
return current.refs();
}
+ @Override
+ public String uuid() {
+ return current.uuid();
+ }
Review Comment:
Well....I probably need to be more thoughtful here since we are working on
multi-table transactions, this wouldn't be just a single UUID? It depends on
if we have a new abstraction for multi-table transactions or we go through
`BaseTransaction.` Thoughts @nastra
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
