jbonofre commented on code in PR #8800:
URL: https://github.com/apache/iceberg/pull/8800#discussion_r1355045037
##########
core/src/main/java/org/apache/iceberg/BaseTransaction.java:
##########
@@ -770,6 +770,11 @@ public Map<String, SnapshotRef> refs() {
return current.refs();
}
+ @Override
+ public String uuid() {
+ return current.uuid();
+ }
Review Comment:
My understanding is that `BaseTransaction` seems to cover a single table
(according to the `TransactionType` enum for instance). So we should be fine
here.
##########
api/src/main/java/org/apache/iceberg/Table.java:
##########
@@ -333,6 +333,15 @@ default UpdateStatistics updateStatistics() {
*/
Map<String, SnapshotRef> refs();
+ /**
+ * Returns the UUID of the table
+ *
+ * @return the UUID of the table
+ */
+ default String uuid() {
+ throw new UnsupportedOperationException(this.getClass().getName() + "
doesn't implement uuid");
Review Comment:
That makes sense: with the default impl, we don't "force" users to refactore
their `TableImpl`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
