marvinlanhenke closed pull request #269: [WIP] Implement project for Transform.
#264
URL: https://github.com/apache/iceberg-rust/pull/269
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
marvinlanhenke commented on PR #269:
URL: https://github.com/apache/iceberg-rust/pull/269#issuecomment-2005814739
> > Hi, @marvinlanhenke This pr looks great to me. But I think @ZENOTME is
right, we should implement #283 first. The reason we implement transform on
arrow array could be found
marvinlanhenke commented on PR #269:
URL: https://github.com/apache/iceberg-rust/pull/269#issuecomment-2005814209
> Hi, @marvinlanhenke This pr looks great to me. But I think @ZENOTME is
right, we should implement #283 first. The reason we implement transform on
arrow array could be found
ZENOTME commented on PR #269:
URL: https://github.com/apache/iceberg-rust/pull/269#issuecomment-2005643728
> Hi, @marvinlanhenke This pr looks great to me. But I think @ZENOTME is
right, we should implement #283 first. The reason we implement transform on
arrow array could be found
[here](
liurenjie1024 commented on PR #269:
URL: https://github.com/apache/iceberg-rust/pull/269#issuecomment-2005621939
Hi, @marvinlanhenke This pr looks great to me. But I think @ZENOTME is
right, we should implement #283 first. The reason we implement transform on
arrow array could be found
[he
liurenjie1024 commented on code in PR #269:
URL: https://github.com/apache/iceberg-rust/pull/269#discussion_r1529594580
##
crates/iceberg/src/expr/predicate.rs:
##
@@ -187,6 +199,14 @@ impl SetExpression {
debug_assert!(op.is_set());
Self { op, term, literals }
ZENOTME commented on PR #269:
URL: https://github.com/apache/iceberg-rust/pull/269#issuecomment-2004158618
Thanks for this job!
> I'm quite unsure about the fn transform and the handling of the
arrow_array - seems kinda clunky?
I think the transform can provide an interface li
marvinlanhenke commented on PR #269:
URL: https://github.com/apache/iceberg-rust/pull/269#issuecomment-2003886408
@liurenjie1024 @sdd @Xuanwo @ZENOTME
I went on and implemented `fn project` for `Transform::Bucket` with some
design assumptions. PTAL and tell me what you think, before we c
marvinlanhenke commented on code in PR #269:
URL: https://github.com/apache/iceberg-rust/pull/269#discussion_r1528347743
##
crates/iceberg/src/spec/transform.rs:
##
@@ -261,6 +269,50 @@ impl Transform {
_ => self == other,
}
}
+/// Projects predica
sdd commented on code in PR #269:
URL: https://github.com/apache/iceberg-rust/pull/269#discussion_r1527606344
##
crates/iceberg/src/spec/transform.rs:
##
@@ -261,6 +269,50 @@ impl Transform {
_ => self == other,
}
}
+/// Projects predicate to `Tran
marvinlanhenke commented on PR #269:
URL: https://github.com/apache/iceberg-rust/pull/269#issuecomment-2002599583
@liurenjie1024 @Xuanwo
the main design concerns I want to discuss:
1. exposing `op` and `literals` from expressions. For prototyping I did this
directly on the express
marvinlanhenke closed pull request #268: WIP: Implement project for Transform
#264
URL: https://github.com/apache/iceberg-rust/pull/268
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
12 matches
Mail list logo
