ZENOTME commented on PR #269:
URL: https://github.com/apache/iceberg-rust/pull/269#issuecomment-2004158618
Thanks for this job!
> I'm quite unsure about the fn transform and the handling of the
arrow_array - seems kinda clunky?
I think the transform can provide an interface like `transform_literal`
later.
```
pub trait TransformFunction: Send {
/// transform will take an input array and transform it into a new array.
/// The implementation of this function will need to check and downcast
the input to specific
/// type.
fn transform(&self, input: ArrayRef) -> Result<ArrayRef>;
+ fn transform_literal(&self, literal:Literal) -> Result<Literal>;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
