liurenjie1024 commented on code in PR #269:
URL: https://github.com/apache/iceberg-rust/pull/269#discussion_r1529594580
##########
crates/iceberg/src/expr/predicate.rs:
##########
@@ -187,6 +199,14 @@ impl<T> SetExpression<T> {
debug_assert!(op.is_set());
Self { op, term, literals }
}
+
+ pub(crate) fn op(&self) -> PredicateOperator {
+ self.op
+ }
+
+ pub(crate) fn literals(&self) -> &FnvHashSet<Datum> {
Review Comment:
```suggestion
pub(crate) fn literals(&self) -> impl Iterator<Item=Datum> {
```
How about returning iterator only? It's better not expose the inner data
structure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
