marvinlanhenke commented on PR #269: URL: https://github.com/apache/iceberg-rust/pull/269#issuecomment-2002599583
@liurenjie1024 @Xuanwo the main design concerns I want to discuss: 1. exposing `op` and `literals` from expressions. For prototyping I did this directly on the expression - it might be better to implement this on `BoundPredicate` itself and expose `op` via pub(crate) from the struct? 2. Once I receive a `PrimitiveLiteral` I need to convert it to an arrow_array in order to perform the transformation. The conversion to the arrow array could also be implemented on `PrimitiveLiteral` itself? I would really appreciate your thoughts on this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
