barronw closed issue #72: Manifest List Writer Design
URL: https://github.com/apache/iceberg-rust/issues/72
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
liurenjie1024 commented on issue #72:
URL: https://github.com/apache/iceberg-rust/issues/72#issuecomment-1754168678
> > The ManifestList is a simple wrapper of Vec, so I think providing a
method for iterator of entries would not be huge effort.
>
> I'm not sure I'm following. To clari
barronw commented on issue #72:
URL: https://github.com/apache/iceberg-rust/issues/72#issuecomment-1754114530
> The ManifestList is a simple wrapper of Vec, so I think providing a method
for iterator of entries would not be huge effort.
I'm not sure I'm following. To clarify, I was wo
ZENOTME commented on issue #72:
URL: https://github.com/apache/iceberg-rust/issues/72#issuecomment-1752043696
> Should we support appending entries like the Java and Python
implementations instead of a single write?
>> The ManifestList is a simple wrapper of Vec, so I think providing a
m
liurenjie1024 commented on issue #72:
URL: https://github.com/apache/iceberg-rust/issues/72#issuecomment-175172
> Should we support appending entries like the Java and Python
implementations instead of a single write?
The `ManifestList` is a simple wrapper of `Vec`, so I think pro
barronw commented on issue #72:
URL: https://github.com/apache/iceberg-rust/issues/72#issuecomment-1751731013
Thanks for the feedback folks! How do we feel about something like this?
```rust
struct ManifestListWriter {
output_file: OutputFile,
format_version: FormatVer
liurenjie1024 commented on issue #72:
URL: https://github.com/apache/iceberg-rust/issues/72#issuecomment-1751583913
> Thanks! We can integrate V1 and V2 into a writer
>
> ```
> struck ManifestListWriter {
>...
> }
>
> impl ManifestListWriter {
> fn write_v1(&mu
ZENOTME commented on issue #72:
URL: https://github.com/apache/iceberg-rust/issues/72#issuecomment-1749958215
cc @liurenjie1024 @Xuanwo @JanKaul @Fokko
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
ZENOTME commented on issue #72:
URL: https://github.com/apache/iceberg-rust/issues/72#issuecomment-1749957317
We can integrate V1 and V2 into a writer
```
struck ManifestListWriter {
...
}
impl ManifestListWriter {
fn write_v1(&mut self, manifest_list: ManifestL
