Xuanwo merged PR #738:
URL: https://github.com/apache/iceberg-rust/pull/738
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.a
liurenjie1024 commented on PR #738:
URL: https://github.com/apache/iceberg-rust/pull/738#issuecomment-2599575267
Let's wait for a moment to see if @Xuanwo has other comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
Xuanwo commented on code in PR #738:
URL: https://github.com/apache/iceberg-rust/pull/738#discussion_r1920298893
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -210,38 +284,207 @@ impl ManifestWriter {
deleted_rows: 0,
min_seq_num: None,
key
liurenjie1024 commented on code in PR #738:
URL: https://github.com/apache/iceberg-rust/pull/738#discussion_r1920149166
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -210,38 +284,207 @@ impl ManifestWriter {
deleted_rows: 0,
min_seq_num: None,
liurenjie1024 commented on code in PR #738:
URL: https://github.com/apache/iceberg-rust/pull/738#discussion_r1919610030
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -114,6 +114,70 @@ impl Manifest {
}
}
+/// The builder used to create a [`ManifestWriter`].
+pub struct M
ZENOTME commented on code in PR #738:
URL: https://github.com/apache/iceberg-rust/pull/738#discussion_r1918244280
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -114,6 +114,70 @@ impl Manifest {
}
}
+/// The builder used to create a [`ManifestWriter`].
+pub struct Manifes
ZENOTME commented on code in PR #738:
URL: https://github.com/apache/iceberg-rust/pull/738#discussion_r1918221289
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -210,38 +281,141 @@ impl ManifestWriter {
deleted_rows: 0,
min_seq_num: None,
ke
ZENOTME commented on PR #738:
URL: https://github.com/apache/iceberg-rust/pull/738#issuecomment-2595160984
> Thanks @ZENOTME for this pr, generally LGTM! I still have concerns with
the add/eixsting/delete api, and prefer the approach used in java api:
org.apache.iceberg.ManifestWriter#add(F
liurenjie1024 commented on code in PR #738:
URL: https://github.com/apache/iceberg-rust/pull/738#discussion_r1918218581
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -210,38 +281,141 @@ impl ManifestWriter {
deleted_rows: 0,
min_seq_num: None,
ZENOTME commented on code in PR #738:
URL: https://github.com/apache/iceberg-rust/pull/738#discussion_r1918213790
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -210,38 +281,141 @@ impl ManifestWriter {
deleted_rows: 0,
min_seq_num: None,
ke
liurenjie1024 commented on code in PR #738:
URL: https://github.com/apache/iceberg-rust/pull/738#discussion_r1918041864
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -210,38 +281,141 @@ impl ManifestWriter {
deleted_rows: 0,
min_seq_num: None,
liurenjie1024 commented on code in PR #738:
URL: https://github.com/apache/iceberg-rust/pull/738#discussion_r1891310066
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -203,12 +206,95 @@ impl ManifestWriter {
partition_summary
}
-/// Write a manifest.
-pub
ZENOTME commented on code in PR #738:
URL: https://github.com/apache/iceberg-rust/pull/738#discussion_r1891257771
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -203,12 +206,95 @@ impl ManifestWriter {
partition_summary
}
-/// Write a manifest.
-pub async
liurenjie1024 commented on code in PR #738:
URL: https://github.com/apache/iceberg-rust/pull/738#discussion_r1891236836
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -203,12 +206,95 @@ impl ManifestWriter {
partition_summary
}
-/// Write a manifest.
-pub
ZENOTME commented on code in PR #738:
URL: https://github.com/apache/iceberg-rust/pull/738#discussion_r1873384095
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -203,12 +206,80 @@ impl ManifestWriter {
partition_summary
}
-/// Write a manifest.
-pub async
liurenjie1024 commented on code in PR #738:
URL: https://github.com/apache/iceberg-rust/pull/738#discussion_r1872484518
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -203,12 +206,80 @@ impl ManifestWriter {
partition_summary
}
-/// Write a manifest.
-pub
ZENOTME commented on code in PR #738:
URL: https://github.com/apache/iceberg-rust/pull/738#discussion_r1868871965
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -203,12 +206,80 @@ impl ManifestWriter {
partition_summary
}
-/// Write a manifest.
-pub async
liurenjie1024 commented on code in PR #738:
URL: https://github.com/apache/iceberg-rust/pull/738#discussion_r1868674850
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -203,12 +206,80 @@ impl ManifestWriter {
partition_summary
}
-/// Write a manifest.
-pub
ZENOTME commented on PR #738:
URL: https://github.com/apache/iceberg-rust/pull/738#issuecomment-2506443194
cc @liurenjie1024 @Xuanwo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
19 matches
Mail list logo
