liurenjie1024 commented on code in PR #738:
URL: https://github.com/apache/iceberg-rust/pull/738#discussion_r1868674850
##########
crates/iceberg/src/spec/manifest.rs:
##########
@@ -203,12 +206,80 @@ impl ManifestWriter {
partition_summary
}
- /// Write a manifest.
- pub async fn write(mut self, manifest: Manifest) -> Result<ManifestFile> {
+ /// Add a new manifest entry.
+ pub fn add(&mut self, mut entry: ManifestEntry) -> Result<()> {
Review Comment:
Applies to other apis.
##########
crates/iceberg/src/spec/manifest.rs:
##########
@@ -203,12 +206,80 @@ impl ManifestWriter {
partition_summary
}
- /// Write a manifest.
- pub async fn write(mut self, manifest: Manifest) -> Result<ManifestFile> {
+ /// Add a new manifest entry.
+ pub fn add(&mut self, mut entry: ManifestEntry) -> Result<()> {
Review Comment:
It's kind of weird of manipulating arguments, how about make the arguments
`DataFile`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
