ZENOTME commented on code in PR #738:
URL: https://github.com/apache/iceberg-rust/pull/738#discussion_r1918244280
##########
crates/iceberg/src/spec/manifest.rs:
##########
@@ -114,6 +114,70 @@ impl Manifest {
}
}
+/// The builder used to create a [`ManifestWriter`].
+pub struct ManifestWriterBuilder {
+ output: OutputFile,
+ snapshot_id: i64,
+ key_metadata: Vec<u8>,
+ schema: SchemaRef,
+ partition_spec: PartitionSpec,
+}
+
+impl ManifestWriterBuilder {
+ /// Create a new builder.
+ pub fn new(
+ output: OutputFile,
+ snapshot_id: i64,
Review Comment:
Which value we should assign in
https://github.com/apache/iceberg-rust/blob/b39d7db8e30400e9bd77a82ecc85a497327f47b8/crates/iceberg/src/spec/manifest.rs#L484C13-L484C26
if it's none. It's a required field.
https://iceberg.apache.org/spec/#manifest-lists:~:text=503%20added_snapshot_id
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
