Re: [PR] pass proxy configuration from environment vars to http client [iceberg]

flyrain commented on code in PR #12406: URL: https://github.com/apache/iceberg/pull/12406#discussion_r1992052511 ## core/src/main/java/org/apache/iceberg/rest/RESTCatalog.java: ## @@ -55,7 +59,50 @@ public class RESTCatalog public RESTCatalog() { this( SessionCa

Re: [PR] pass proxy configuration from environment vars to http client [iceberg]

akhilputhiry commented on code in PR #12406: URL: https://github.com/apache/iceberg/pull/12406#discussion_r1991755395 ## core/src/main/java/org/apache/iceberg/rest/RESTCatalog.java: ## @@ -55,7 +56,22 @@ public class RESTCatalog public RESTCatalog() { this( Sess

Re: [PR] pass proxy configuration from environment vars to http client [iceberg]

adutra commented on code in PR #12406: URL: https://github.com/apache/iceberg/pull/12406#discussion_r1991498775 ## core/src/main/java/org/apache/iceberg/CatalogProperties.java: ## @@ -32,6 +32,18 @@ private CatalogProperties() {} public static final String VIEW_DEFAULT_PREFIX

Re: [PR] pass proxy configuration from environment vars to http client [iceberg]

adutra commented on code in PR #12406: URL: https://github.com/apache/iceberg/pull/12406#discussion_r1991493796 ## core/src/main/java/org/apache/iceberg/rest/RESTCatalog.java: ## @@ -55,7 +56,22 @@ public class RESTCatalog public RESTCatalog() { this( SessionCat

Re: [PR] pass proxy configuration from environment vars to http client [iceberg]

akhilputhiry commented on code in PR #12406: URL: https://github.com/apache/iceberg/pull/12406#discussion_r1984518742 ## core/src/main/java/org/apache/iceberg/rest/RESTCatalog.java: ## @@ -55,7 +56,22 @@ public class RESTCatalog public RESTCatalog() { this( Sess

Re: [PR] pass proxy configuration from environment vars to http client [iceberg]

akhilputhiry commented on code in PR #12406: URL: https://github.com/apache/iceberg/pull/12406#discussion_r1984523655 ## core/src/main/java/org/apache/iceberg/rest/RESTCatalog.java: ## @@ -55,7 +56,22 @@ public class RESTCatalog public RESTCatalog() { this( Sess

Re: [PR] pass proxy configuration from environment vars to http client [iceberg]

adutra commented on code in PR #12406: URL: https://github.com/apache/iceberg/pull/12406#discussion_r1983799256 ## core/src/main/java/org/apache/iceberg/rest/RESTCatalog.java: ## @@ -55,7 +56,22 @@ public class RESTCatalog public RESTCatalog() { this( SessionCat

Re: [PR] pass proxy configuration from environment vars to http client [iceberg]

akhilputhiry commented on PR #12406: URL: https://github.com/apache/iceberg/pull/12406#issuecomment-2689600902 > Can you confirm that adding ProxySupport on top of the existing code will work, e.g. if withProxy is used? > Yes it works, I had tested with `org.apache.iceberg.rest.HTTPCl

Re: [PR] pass proxy configuration from environment vars to http client [iceberg]

adutra commented on PR #12406: URL: https://github.com/apache/iceberg/pull/12406#issuecomment-264965 Hi @akhilputhiry while I understand the problem I think there are a few concerns with this PR: First off, there is already some proxy support in `HTTPClient`: 1. `org.apache

Re: [PR] pass proxy configuration from environment vars to http client [iceberg]

akhilputhiry commented on PR #12406: URL: https://github.com/apache/iceberg/pull/12406#issuecomment-2688573051 @adutra Could you please take a look at this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] pass proxy configuration from environment vars to http client [iceberg]

akhilputhiry commented on PR #12406: URL: https://github.com/apache/iceberg/pull/12406#issuecomment-2686727721 @flyrain Could you please take a look at this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[PR] pass proxy configuration from environment vars to http client [iceberg]

akhilputhiry opened a new pull request, #12406: URL: https://github.com/apache/iceberg/pull/12406 This PR Fixes https://github.com/apache/iceberg/issues/12059 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL