Re: [PR] feat: support position delete writer [iceberg-rust]

ZENOTME commented on PR #704: URL: https://github.com/apache/iceberg-rust/pull/704#issuecomment-2693595000 hi @liurenjie1024, is there other improvement for this PR? I think it's ready to go. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] feat: support position delete writer [iceberg-rust]

liurenjie1024 commented on code in PR #704: URL: https://github.com/apache/iceberg-rust/pull/704#discussion_r1976816015 ## crates/iceberg/src/writer/base_writer/position_delete_file_writer.rs: ## @@ -0,0 +1,277 @@ +// Licensed to the Apache Software Foundation (ASF) under one +/

Re: [PR] feat: support position delete writer [iceberg-rust]

ZENOTME commented on code in PR #704: URL: https://github.com/apache/iceberg-rust/pull/704#discussion_r1972829889 ## crates/iceberg/src/writer/base_writer/position_delete_file_writer.rs: ## @@ -0,0 +1,277 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or m

Re: [PR] feat: support position delete writer [iceberg-rust]

liurenjie1024 commented on code in PR #704: URL: https://github.com/apache/iceberg-rust/pull/704#discussion_r1972684368 ## crates/iceberg/src/writer/base_writer/position_delete_file_writer.rs: ## @@ -0,0 +1,277 @@ +// Licensed to the Apache Software Foundation (ASF) under one +/

Re: [PR] feat: support position delete writer [iceberg-rust]

ZENOTME commented on code in PR #704: URL: https://github.com/apache/iceberg-rust/pull/704#discussion_r1968910011 ## crates/iceberg/src/writer/base_writer/position_delete_file_writer.rs: ## @@ -0,0 +1,277 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or m

Re: [PR] feat: support position delete writer [iceberg-rust]

liurenjie1024 commented on code in PR #704: URL: https://github.com/apache/iceberg-rust/pull/704#discussion_r1968813999 ## crates/iceberg/src/writer/base_writer/position_delete_file_writer.rs: ## @@ -0,0 +1,277 @@ +// Licensed to the Apache Software Foundation (ASF) under one +/

Re: [PR] feat: support position delete writer [iceberg-rust]

ZENOTME commented on code in PR #704: URL: https://github.com/apache/iceberg-rust/pull/704#discussion_r1966682923 ## crates/iceberg/src/writer/base_writer/position_delete_file_writer.rs: ## @@ -0,0 +1,277 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or m

Re: [PR] feat: support position delete writer [iceberg-rust]

ZENOTME commented on code in PR #704: URL: https://github.com/apache/iceberg-rust/pull/704#discussion_r1966554217 ## crates/iceberg/src/writer/base_writer/position_delete_file_writer.rs: ## @@ -0,0 +1,245 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or m

Re: [PR] feat: support position delete writer [iceberg-rust]

liurenjie1024 commented on code in PR #704: URL: https://github.com/apache/iceberg-rust/pull/704#discussion_r1962828050 ## crates/iceberg/src/writer/base_writer/position_delete_file_writer.rs: ## @@ -0,0 +1,245 @@ +// Licensed to the Apache Software Foundation (ASF) under one +/

Re: [PR] feat: support position delete writer [iceberg-rust]

jonathanc-n commented on code in PR #704: URL: https://github.com/apache/iceberg-rust/pull/704#discussion_r1953805959 ## crates/iceberg/src/writer/base_writer/position_delete_file_writer.rs: ## @@ -0,0 +1,245 @@ +// Licensed to the Apache Software Foundation (ASF) under one +//

Re: [PR] feat: support position delete writer [iceberg-rust]

jonathanc-n commented on code in PR #704: URL: https://github.com/apache/iceberg-rust/pull/704#discussion_r1953805959 ## crates/iceberg/src/writer/base_writer/position_delete_file_writer.rs: ## @@ -0,0 +1,245 @@ +// Licensed to the Apache Software Foundation (ASF) under one +//

Re: [PR] feat: support position delete writer [iceberg-rust]

ZENOTME commented on PR #704: URL: https://github.com/apache/iceberg-rust/pull/704#issuecomment-2653718497 Hi @liurenjie1024 @jonathanc-n. I have fixed this PR. It's ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] feat: support position delete writer [iceberg-rust]

ZENOTME commented on PR #704: URL: https://github.com/apache/iceberg-rust/pull/704#issuecomment-2653556089 > @ZENOTME Are you still working on this? I'm looking to work on one of the two writers Sorry for the late, I will work on this later. Would you like to work on sorting position

Re: [PR] feat: support position delete writer [iceberg-rust]

jonathanc-n commented on PR #704: URL: https://github.com/apache/iceberg-rust/pull/704#issuecomment-2652921810 @ZENOTME Are you still working on this? I'm looking to work on one of the two writers -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] feat: support position delete writer [iceberg-rust]

ZENOTME commented on PR #704: URL: https://github.com/apache/iceberg-rust/pull/704#issuecomment-2513388680 I think we can resolve #741 first before this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] feat: support position delete writer [iceberg-rust]

ZENOTME commented on code in PR #704: URL: https://github.com/apache/iceberg-rust/pull/704#discussion_r1862125870 ## crates/iceberg/src/writer/base_writer/position_delete_file_writer.rs: ## @@ -0,0 +1,320 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or m

Re: [PR] feat: support position delete writer [iceberg-rust]

ZENOTME commented on PR #704: URL: https://github.com/apache/iceberg-rust/pull/704#issuecomment-2505206247 > > > There are two kinds of writers in iceberg: > > > > > > 1. Plain position delete writer: https://github.com/apache/iceberg/blob/da2ad389fd9ba8222f6fb3f57922209c239a7045/core

Re: [PR] feat: support position delete writer [iceberg-rust]

liurenjie1024 commented on PR #704: URL: https://github.com/apache/iceberg-rust/pull/704#issuecomment-2505139679 > > There are two kinds of writers in iceberg: > > > > 1. Plain position delete writer: https://github.com/apache/iceberg/blob/da2ad389fd9ba8222f6fb3f57922209c239a7045/core

Re: [PR] feat: support position delete writer [iceberg-rust]

ZENOTME commented on PR #704: URL: https://github.com/apache/iceberg-rust/pull/704#issuecomment-2503873873 > There are two kinds of writers in iceberg: > > 1. Plain position delete writer: https://github.com/apache/iceberg/blob/da2ad389fd9ba8222f6fb3f57922209c239a7045/core/src/main/ja

Re: [PR] feat: support position delete writer [iceberg-rust]

liurenjie1024 commented on code in PR #704: URL: https://github.com/apache/iceberg-rust/pull/704#discussion_r1860049342 ## crates/iceberg/src/writer/base_writer/position_delete_file_writer.rs: ## @@ -0,0 +1,320 @@ +// Licensed to the Apache Software Foundation (ASF) under one +/