ZENOTME commented on code in PR #704: URL: https://github.com/apache/iceberg-rust/pull/704#discussion_r1966554217
########## crates/iceberg/src/writer/base_writer/position_delete_file_writer.rs: ########## @@ -0,0 +1,245 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! Position delete file writer. +use std::sync::Arc; + +use arrow_array::builder::{PrimitiveBuilder, StringBuilder}; +use arrow_array::types::Int64Type; +use arrow_array::RecordBatch; +use once_cell::sync::Lazy; + +use crate::arrow::schema_to_arrow_schema; +use crate::spec::{DataContentType, DataFile, NestedField, PrimitiveType, Schema, Struct, Type}; +use crate::writer::file_writer::{FileWriter, FileWriterBuilder}; +use crate::writer::{IcebergWriter, IcebergWriterBuilder}; +use crate::{Error, ErrorKind, Result}; + +static POSITION_DELETE_SCHEMA: Lazy<Schema> = Lazy::new(|| { + Schema::builder() + .with_fields(vec![ + Arc::new(NestedField::required( + 2147483546, + "file_path", + Type::Primitive(PrimitiveType::String), + )), + Arc::new(NestedField::required( + 2147483545, + "pos", + Type::Primitive(PrimitiveType::Long), + )), + ]) + .build() + .unwrap() +}); + +/// Position delete input. +#[derive(Clone, PartialEq, Eq, Ord, PartialOrd, Debug)] +pub struct PositionDeleteInput { + /// The path of the file. + pub path: String, + /// The offset of the position delete. + pub offsets: Vec<i64>, +} + +impl PositionDeleteInput { + /// Create a new `PositionDeleteInput`. + pub fn new(path: String, offsets: Vec<i64>) -> Self { + PositionDeleteInput { path, offsets } + } +} +/// Builder for `MemoryPositionDeleteWriter`. +#[derive(Clone)] +pub struct PositionDeleteWriterBuilder<B: FileWriterBuilder> { + inner: B, + partition_value: Option<Struct>, +} + +impl<B: FileWriterBuilder> PositionDeleteWriterBuilder<B> { + /// Create a new `MemoryPositionDeleteWriterBuilder` using a `FileWriterBuilder`. + pub fn new(inner: B, partition_value: Option<Struct>) -> Self { + Self { + inner, + partition_value, + } + } +} + +#[async_trait::async_trait] +impl<B: FileWriterBuilder> IcebergWriterBuilder<Vec<PositionDeleteInput>> + for PositionDeleteWriterBuilder<B> +{ + type R = PositionDeleteWriter<B>; + + async fn build(self) -> Result<Self::R> { + Ok(PositionDeleteWriter { + inner_writer: Some(self.inner.build().await?), + partition_value: self.partition_value.unwrap_or(Struct::empty()), + }) + } +} + +/// Position delete writer. +pub struct PositionDeleteWriter<B: FileWriterBuilder> { Review Comment: Do you mean that for `PositionDeleteInput`, we should buffer them and write them as a batch?🤔 E.g. ``` pub struct PositionDeleteWriter { // path -> row_num buffer: HashMap<String, Vec<i64>> } ``` For here I don't add the buffer because we will add SortPositionDeleteWriter later and it will buffer the input and sort them, so I'm not sure whether we need to add a buffer here. Or we can let it be a optional choice? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
