Fokko commented on PR #74:
URL: https://github.com/apache/iceberg-cpp/pull/74#issuecomment-2807429010
Thanks for working on this @zhjwpku, and thanks for the review @lidavidm,
@yingcai-cy and @wgtmac 🙌
--
This is an automated message from the Apache Git Service.
To respond to the message
Fokko merged PR #74:
URL: https://github.com/apache/iceberg-cpp/pull/74
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach
zhjwpku commented on PR #74:
URL: https://github.com/apache/iceberg-cpp/pull/74#issuecomment-2805025426
I've updated the PR to use `ToJson` as the serialization function name, also
only write the summary map when there is an operation, this is the same
behavior from java impl[1]
[1]
zhjwpku commented on code in PR #74:
URL: https://github.com/apache/iceberg-cpp/pull/74#discussion_r2043603653
##
src/iceberg/json_internal.cc:
##
@@ -231,6 +296,53 @@ nlohmann::json SchemaToJson(const Schema& schema) {
return json;
}
+nlohmann::json SnapshotRefToJson(cons
zhjwpku commented on code in PR #74:
URL: https://github.com/apache/iceberg-cpp/pull/74#discussion_r2044911397
##
src/iceberg/json_internal.cc:
##
@@ -419,4 +520,75 @@ Result>
PartitionSpecFromJson(
return std::make_unique(schema, spec_id,
std::move(partition_fields));
}
wgtmac commented on code in PR #74:
URL: https://github.com/apache/iceberg-cpp/pull/74#discussion_r2044876359
##
src/iceberg/json_internal.cc:
##
@@ -419,4 +520,75 @@ Result>
PartitionSpecFromJson(
return std::make_unique(schema, spec_id,
std::move(partition_fields));
}
Fokko commented on code in PR #74:
URL: https://github.com/apache/iceberg-cpp/pull/74#discussion_r2044843490
##
src/iceberg/json_internal.cc:
##
@@ -419,4 +520,75 @@ Result>
PartitionSpecFromJson(
return std::make_unique(schema, spec_id,
std::move(partition_fields));
}
+
zhjwpku commented on code in PR #74:
URL: https://github.com/apache/iceberg-cpp/pull/74#discussion_r2044591101
##
src/iceberg/json_internal.cc:
##
@@ -419,4 +523,77 @@ Result>
PartitionSpecFromJson(
return std::make_unique(schema, spec_id,
std::move(partition_fields));
}
wgtmac commented on code in PR #74:
URL: https://github.com/apache/iceberg-cpp/pull/74#discussion_r2044572526
##
src/iceberg/json_internal.cc:
##
@@ -419,4 +523,77 @@ Result>
PartitionSpecFromJson(
return std::make_unique(schema, spec_id,
std::move(partition_fields));
}
wgtmac commented on code in PR #74:
URL: https://github.com/apache/iceberg-cpp/pull/74#discussion_r2044455111
##
src/iceberg/json_internal.cc:
##
@@ -419,4 +520,75 @@ Result>
PartitionSpecFromJson(
return std::make_unique(schema, spec_id,
std::move(partition_fields));
}
wgtmac commented on code in PR #74:
URL: https://github.com/apache/iceberg-cpp/pull/74#discussion_r202952
##
src/iceberg/json_internal.cc:
##
@@ -419,4 +520,75 @@ Result>
PartitionSpecFromJson(
return std::make_unique(schema, spec_id,
std::move(partition_fields));
}
zhjwpku commented on code in PR #74:
URL: https://github.com/apache/iceberg-cpp/pull/74#discussion_r2044266834
##
src/iceberg/snapshot.h:
##
@@ -139,11 +196,11 @@ struct SnapshotSummaryFields {
/// Other Fields, see https://iceberg.apache.org/spec/#other-fields
/// \brie
yingcai-cy commented on code in PR #74:
URL: https://github.com/apache/iceberg-cpp/pull/74#discussion_r2044137927
##
src/iceberg/snapshot.h:
##
@@ -139,11 +196,11 @@ struct SnapshotSummaryFields {
/// Other Fields, see https://iceberg.apache.org/spec/#other-fields
/// \b
zhjwpku commented on code in PR #74:
URL: https://github.com/apache/iceberg-cpp/pull/74#discussion_r2043599178
##
src/iceberg/json_internal.cc:
##
@@ -231,6 +296,53 @@ nlohmann::json SchemaToJson(const Schema& schema) {
return json;
}
+nlohmann::json SnapshotRefToJson(cons
zhjwpku commented on code in PR #74:
URL: https://github.com/apache/iceberg-cpp/pull/74#discussion_r2043598305
##
src/iceberg/snapshot.h:
##
@@ -54,13 +77,35 @@ struct ICEBERG_EXPORT SnapshotRef {
/// of the snapshot reference to keep while expiring snapshots. Defaults
to
zhjwpku commented on code in PR #74:
URL: https://github.com/apache/iceberg-cpp/pull/74#discussion_r2043592188
##
src/iceberg/json_internal.cc:
##
@@ -231,6 +296,53 @@ nlohmann::json SchemaToJson(const Schema& schema) {
return json;
}
+nlohmann::json SnapshotRefToJson(cons
zhjwpku commented on code in PR #74:
URL: https://github.com/apache/iceberg-cpp/pull/74#discussion_r2043592188
##
src/iceberg/json_internal.cc:
##
@@ -231,6 +296,53 @@ nlohmann::json SchemaToJson(const Schema& schema) {
return json;
}
+nlohmann::json SnapshotRefToJson(cons
zhjwpku commented on code in PR #74:
URL: https://github.com/apache/iceberg-cpp/pull/74#discussion_r2043592188
##
src/iceberg/json_internal.cc:
##
@@ -231,6 +296,53 @@ nlohmann::json SchemaToJson(const Schema& schema) {
return json;
}
+nlohmann::json SnapshotRefToJson(cons
wgtmac commented on code in PR #74:
URL: https://github.com/apache/iceberg-cpp/pull/74#discussion_r2043358743
##
src/iceberg/json_internal.cc:
##
@@ -231,6 +296,53 @@ nlohmann::json SchemaToJson(const Schema& schema) {
return json;
}
+nlohmann::json SnapshotRefToJson(const
wgtmac commented on code in PR #74:
URL: https://github.com/apache/iceberg-cpp/pull/74#discussion_r2043357992
##
src/iceberg/json_internal.cc:
##
@@ -231,6 +296,53 @@ nlohmann::json SchemaToJson(const Schema& schema) {
return json;
}
+nlohmann::json SnapshotRefToJson(const
wgtmac commented on code in PR #74:
URL: https://github.com/apache/iceberg-cpp/pull/74#discussion_r2042433243
##
src/iceberg/snapshot.h:
##
@@ -54,13 +77,35 @@ struct ICEBERG_EXPORT SnapshotRef {
/// of the snapshot reference to keep while expiring snapshots. Defaults
to t
lidavidm commented on code in PR #74:
URL: https://github.com/apache/iceberg-cpp/pull/74#discussion_r2043228407
##
test/json_internal_test.cc:
##
@@ -148,4 +148,96 @@ TEST(JsonPartitionTest, PartitionSpec) {
EXPECT_EQ(spec, *parsed_spec_result.value());
}
+TEST(JsonInterna
22 matches
Mail list logo
