yingcai-cy commented on code in PR #74:
URL: https://github.com/apache/iceberg-cpp/pull/74#discussion_r2044137927
##########
src/iceberg/snapshot.h:
##########
@@ -139,11 +196,11 @@ struct SnapshotSummaryFields {
/// Other Fields, see https://iceberg.apache.org/spec/#other-fields
/// \brief The Write-Audit-Publish id of a staged snapshot
- inline static const std::string kWAPID = "wap.id";
+ inline static const std::string kWAPId = "wap.id";
Review Comment:
Just curious，is there a reason for using a different style of const string
here? why not use “inline constexpr std::string_view
”
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
