zhjwpku commented on code in PR #74:
URL: https://github.com/apache/iceberg-cpp/pull/74#discussion_r2043598305
##########
src/iceberg/snapshot.h:
##########
@@ -54,13 +77,35 @@ struct ICEBERG_EXPORT SnapshotRef {
/// of the snapshot reference to keep while expiring snapshots. Defaults
to table
/// property history.expire.max-ref-age-ms. The main branch never expires.
std::optional<int64_t> max_ref_age_ms;
+
+ /// \brief Compare two branches for equality.
+ friend bool operator==(const Branch& lhs, const Branch& rhs) {
Review Comment:
Tried, but failed with:
```
error: invalid operands to binary expression ('const
iceberg::SnapshotRef::Tag' and 'const iceberg::SnapshotRef::Tag')
61 | std::get<Tag>(retention) ==
std::get<Tag>(other.retention);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
