zhjwpku commented on code in PR #74:
URL: https://github.com/apache/iceberg-cpp/pull/74#discussion_r2044266834
##########
src/iceberg/snapshot.h:
##########
@@ -139,11 +196,11 @@ struct SnapshotSummaryFields {
/// Other Fields, see https://iceberg.apache.org/spec/#other-fields
/// \brief The Write-Audit-Publish id of a staged snapshot
- inline static const std::string kWAPID = "wap.id";
+ inline static const std::string kWAPId = "wap.id";
Review Comment:
Hah, we discussed about this in #60, because of SSO(Small String
Optimization), `inline constexpr std::string_view` can only handle small
string(typically up to 15-23 characters, depending on the implementation), thus
changed to `inline static const std::string`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
