Re: [PR] feat(io): Add Create method for creating file writers [iceberg-go]

2025-01-21 Thread via GitHub
zeroshade commented on code in PR #262: URL: https://github.com/apache/iceberg-go/pull/262#discussion_r1924101964 ## io/local.go: ## @@ -30,6 +31,18 @@ func (LocalFS) Open(name string) (File, error) { return os.Open(strings.TrimPrefix(name, "file://")) } +func (LocalF

Re: [PR] feat(io): Add Create method for creating file writers [iceberg-go]

2025-01-21 Thread via GitHub
zeroshade merged PR #262: URL: https://github.com/apache/iceberg-go/pull/262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [PR] feat(io): Add Create method for creating file writers [iceberg-go]

2025-01-21 Thread via GitHub
kevinjqliu commented on code in PR #262: URL: https://github.com/apache/iceberg-go/pull/262#discussion_r1924087398 ## io/local.go: ## @@ -30,6 +31,18 @@ func (LocalFS) Open(name string) (File, error) { return os.Open(strings.TrimPrefix(name, "file://")) } +func (Local

Re: [PR] feat(io): Add Create method for creating file writers [iceberg-go]

2025-01-21 Thread via GitHub
kevinjqliu commented on code in PR #262: URL: https://github.com/apache/iceberg-go/pull/262#discussion_r1924082827 ## io/blob.go: ## @@ -106,6 +106,10 @@ func (bfs *blobFileIO) Remove(name string) error { return bfs.Bucket.Delete(context.Background(), name) } +func (b

Re: [PR] feat(io): Add Create method for creating file writers [iceberg-go]

2025-01-21 Thread via GitHub
zeroshade commented on code in PR #262: URL: https://github.com/apache/iceberg-go/pull/262#discussion_r1924082071 ## io/local.go: ## @@ -30,6 +31,18 @@ func (LocalFS) Open(name string) (File, error) { return os.Open(strings.TrimPrefix(name, "file://")) } +func (LocalF

Re: [PR] feat(io): Add Create method for creating file writers [iceberg-go]

2025-01-21 Thread via GitHub
zeroshade commented on code in PR #262: URL: https://github.com/apache/iceberg-go/pull/262#discussion_r1924079606 ## io/blob.go: ## @@ -106,6 +106,10 @@ func (bfs *blobFileIO) Remove(name string) error { return bfs.Bucket.Delete(context.Background(), name) } +func (bf

Re: [PR] feat(io): Add Create method for creating file writers [iceberg-go]

2025-01-21 Thread via GitHub
kevinjqliu commented on code in PR #262: URL: https://github.com/apache/iceberg-go/pull/262#discussion_r1924072633 ## io/local.go: ## @@ -30,6 +31,18 @@ func (LocalFS) Open(name string) (File, error) { return os.Open(strings.TrimPrefix(name, "file://")) } +func (Local

Re: [PR] feat(io): Add Create method for creating file writers [iceberg-go]

2025-01-21 Thread via GitHub
zeroshade commented on code in PR #262: URL: https://github.com/apache/iceberg-go/pull/262#discussion_r1924057162 ## io/local.go: ## @@ -30,6 +31,18 @@ func (LocalFS) Open(name string) (File, error) { return os.Open(strings.TrimPrefix(name, "file://")) } +func (LocalF

Re: [PR] feat(io): Add Create method for creating file writers [iceberg-go]

2025-01-21 Thread via GitHub
kevinjqliu commented on code in PR #262: URL: https://github.com/apache/iceberg-go/pull/262#discussion_r1924054615 ## io/blob.go: ## @@ -106,6 +106,10 @@ func (bfs *blobFileIO) Remove(name string) error { return bfs.Bucket.Delete(context.Background(), name) } +func (b

Re: [PR] feat(io): Add Create method for creating file writers [iceberg-go]

2025-01-21 Thread via GitHub
zeroshade commented on code in PR #262: URL: https://github.com/apache/iceberg-go/pull/262#discussion_r1923941157 ## io/blob.go: ## @@ -106,6 +106,10 @@ func (bfs *blobFileIO) Remove(name string) error { return bfs.Bucket.Delete(context.Background(), name) } +func (bf

Re: [PR] feat(io): Add Create method for creating file writers [iceberg-go]

2025-01-20 Thread via GitHub
kevinjqliu commented on code in PR #262: URL: https://github.com/apache/iceberg-go/pull/262#discussion_r1923118119 ## io/local.go: ## @@ -30,6 +31,18 @@ func (LocalFS) Open(name string) (File, error) { return os.Open(strings.TrimPrefix(name, "file://")) } +func (Local