zeroshade commented on code in PR #262:
URL: https://github.com/apache/iceberg-go/pull/262#discussion_r1924057162
##########
io/local.go:
##########
@@ -30,6 +31,18 @@ func (LocalFS) Open(name string) (File, error) {
return os.Open(strings.TrimPrefix(name, "file://"))
}
+func (LocalFS) Create(name string) (FileWriter, error) {
+ filename := strings.TrimPrefix(name, "file://")
+ if err := os.MkdirAll(filepath.Dir(filename), 0755); err != nil {
Review Comment:
I kinda just picked the modes out of a hat for defaults as they made sense,
perhaps they should both be 0644?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
