zeroshade commented on code in PR #262:
URL: https://github.com/apache/iceberg-go/pull/262#discussion_r1924082071


##########
io/local.go:
##########
@@ -30,6 +31,18 @@ func (LocalFS) Open(name string) (File, error) {
        return os.Open(strings.TrimPrefix(name, "file://"))
 }
 
+func (LocalFS) Create(name string) (FileWriter, error) {
+       filename := strings.TrimPrefix(name, "file://")
+       if err := os.MkdirAll(filepath.Dir(filename), 0755); err != nil {

Review Comment:
   Is there a common default used by pyiceberg or java-iceberg when creating 
the metadata directories or other file directory creation?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to