zeroshade commented on code in PR #262:
URL: https://github.com/apache/iceberg-go/pull/262#discussion_r1923941157


##########
io/blob.go:
##########
@@ -106,6 +106,10 @@ func (bfs *blobFileIO) Remove(name string) error {
        return bfs.Bucket.Delete(context.Background(), name)
 }
 
+func (bfs *blobFileIO) Create(name string) (FileWriter, error) {
+       return bfs.NewWriter(name, true, nil)
+}
+

Review Comment:
   the embedded blobwriter already implements WriteFile, so we don't have to do 
it ourselves



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to