xxchan commented on code in PR #445:
URL: https://github.com/apache/iceberg-rust/pull/445#discussion_r1897190743
##
.github/workflows/ci.yml:
##
@@ -63,8 +72,14 @@ jobs:
- windows-latest
steps:
- uses: actions/checkout@v4
+
+ - name: Setup Rust toolch
xxchan commented on code in PR #445:
URL: https://github.com/apache/iceberg-rust/pull/445#discussion_r1897190259
##
.github/workflows/ci.yml:
##
@@ -63,8 +72,14 @@ jobs:
- windows-latest
steps:
- uses: actions/checkout@v4
+
+ - name: Setup Rust toolch
Fokko merged PR #445:
URL: https://github.com/apache/iceberg-rust/pull/445
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
liurenjie1024 commented on code in PR #445:
URL: https://github.com/apache/iceberg-rust/pull/445#discussion_r166858
##
.github/workflows/publish.yml:
##
@@ -42,9 +40,11 @@ jobs:
- "crates/catalog/rest"
steps:
- uses: actions/checkout@v4
- - name:
liurenjie1024 commented on code in PR #445:
URL: https://github.com/apache/iceberg-rust/pull/445#discussion_r1668577343
##
.github/workflows/ci.yml:
##
@@ -61,14 +84,29 @@ jobs:
- windows-latest
steps:
- uses: actions/checkout@v4
+
+ - name: Install R
liurenjie1024 commented on code in PR #445:
URL: https://github.com/apache/iceberg-rust/pull/445#discussion_r1668575871
##
.github/workflows/ci.yml:
##
@@ -29,6 +29,10 @@ concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
cancel-in-progre
liurenjie1024 commented on code in PR #445:
URL: https://github.com/apache/iceberg-rust/pull/445#discussion_r1668576507
##
.github/workflows/ci.yml:
##
@@ -29,6 +29,10 @@ concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
cancel-in-progre
Xuanwo commented on PR #445:
URL: https://github.com/apache/iceberg-rust/pull/445#issuecomment-2212312703
Perhaps we can update the contributing guide with the versions we used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
Xuanwo commented on code in PR #445:
URL: https://github.com/apache/iceberg-rust/pull/445#discussion_r1667600760
##
.github/workflows/ci.yml:
##
@@ -29,6 +29,10 @@ concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
cancel-in-progress: tru
liurenjie1024 commented on code in PR #445:
URL: https://github.com/apache/iceberg-rust/pull/445#discussion_r1667600732
##
.github/actions/setup-builder/action.yml:
##
Review Comment:
This file is heavily inspire by
[datafusion](https://github.com/apache/datafusion/blob/ma
liurenjie1024 commented on code in PR #445:
URL: https://github.com/apache/iceberg-rust/pull/445#discussion_r1667368210
##
Makefile:
##
@@ -19,25 +19,31 @@
RUST_LOG = debug
+RUST_NIGHTLY_CHANNEL = nightly-2024-06-10
Review Comment:
Oh, I get your point. So you mean to m
Xuanwo commented on code in PR #445:
URL: https://github.com/apache/iceberg-rust/pull/445#discussion_r1667358433
##
Makefile:
##
@@ -19,25 +19,31 @@
RUST_LOG = debug
+RUST_NIGHTLY_CHANNEL = nightly-2024-06-10
Review Comment:
Hi, my current plan is we have three rust ver
Xuanwo commented on code in PR #445:
URL: https://github.com/apache/iceberg-rust/pull/445#discussion_r1667358433
##
Makefile:
##
@@ -19,25 +19,31 @@
RUST_LOG = debug
+RUST_NIGHTLY_CHANNEL = nightly-2024-06-10
Review Comment:
Hi, my current plan is we have three rust ver
Xuanwo commented on code in PR #445:
URL: https://github.com/apache/iceberg-rust/pull/445#discussion_r1667358433
##
Makefile:
##
@@ -19,25 +19,31 @@
RUST_LOG = debug
+RUST_NIGHTLY_CHANNEL = nightly-2024-06-10
Review Comment:
Hi, my current plan is we have three rust ver
liurenjie1024 commented on code in PR #445:
URL: https://github.com/apache/iceberg-rust/pull/445#discussion_r1667347496
##
Makefile:
##
@@ -19,25 +19,31 @@
RUST_LOG = debug
+RUST_NIGHTLY_CHANNEL = nightly-2024-06-10
Review Comment:
I have concerns about smiply using lat
Xuanwo commented on code in PR #445:
URL: https://github.com/apache/iceberg-rust/pull/445#discussion_r1667345517
##
Makefile:
##
@@ -19,25 +19,31 @@
RUST_LOG = debug
+RUST_NIGHTLY_CHANNEL = nightly-2024-06-10
Review Comment:
> Do you mean to use nightly to build?
liurenjie1024 commented on code in PR #445:
URL: https://github.com/apache/iceberg-rust/pull/445#discussion_r1667342779
##
Makefile:
##
@@ -19,25 +19,31 @@
RUST_LOG = debug
+RUST_NIGHTLY_CHANNEL = nightly-2024-06-10
Review Comment:
Do you mean to use nightly to build?
Xuanwo commented on code in PR #445:
URL: https://github.com/apache/iceberg-rust/pull/445#discussion_r1667337567
##
Makefile:
##
@@ -19,25 +19,31 @@
RUST_LOG = debug
+RUST_NIGHTLY_CHANNEL = nightly-2024-06-10
Review Comment:
Hi, as I proposed in https://github.com/apach
Xuanwo commented on code in PR #445:
URL: https://github.com/apache/iceberg-rust/pull/445#discussion_r1667337567
##
Makefile:
##
@@ -19,25 +19,31 @@
RUST_LOG = debug
+RUST_NIGHTLY_CHANNEL = nightly-2024-06-10
Review Comment:
Hi, as I proposed in https://github.com/apach
19 matches
Mail list logo
