xxchan commented on code in PR #445: URL: https://github.com/apache/iceberg-rust/pull/445#discussion_r1897190743
########## .github/workflows/ci.yml: ########## @@ -63,8 +72,14 @@ jobs: - windows-latest steps: - uses: actions/checkout@v4 + + - name: Setup Rust toolchain + uses: ./.github/actions/setup-builder + with: + rust-version: ${{ env.rust_msrv }} + - name: Build - run: cargo build + run: make build Review Comment: We should `cargo +${{ env.rust_msrv}} build`, or `rustup override set ${{ env.rust_msrv}}` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org