rdblue commented on code in PR #12374:
URL: https://github.com/apache/iceberg/pull/12374#discussion_r1966203879
##
api/src/test/java/org/apache/iceberg/variants/TestSerializedMetadata.java:
##
@@ -44,7 +44,7 @@ public void testEmptyVariantMetadata() {
@Test
public void t
aihuaxu commented on code in PR #12374:
URL: https://github.com/apache/iceberg/pull/12374#discussion_r1966134331
##
api/src/test/java/org/apache/iceberg/variants/TestSerializedMetadata.java:
##
@@ -44,7 +44,7 @@ public void testEmptyVariantMetadata() {
@Test
public void
rdblue commented on code in PR #12374:
URL: https://github.com/apache/iceberg/pull/12374#discussion_r1966110815
##
api/src/main/java/org/apache/iceberg/variants/SerializedMetadata.java:
##
@@ -23,15 +23,16 @@
import
org.apache.iceberg.relocated.com.google.common.annotations.Vi
rdblue commented on code in PR #12374:
URL: https://github.com/apache/iceberg/pull/12374#discussion_r1966111525
##
api/src/main/java/org/apache/iceberg/variants/VariantValue.java:
##
@@ -59,4 +59,21 @@ default VariantObject asObject() {
default VariantArray asArray() {
t
rdblue commented on code in PR #12374:
URL: https://github.com/apache/iceberg/pull/12374#discussion_r1966109918
##
api/src/main/java/org/apache/iceberg/variants/SerializedObject.java:
##
@@ -133,8 +132,8 @@ public boolean hasNext() {
}
@Override
-
rdblue commented on code in PR #12374:
URL: https://github.com/apache/iceberg/pull/12374#discussion_r1966109369
##
api/src/main/java/org/apache/iceberg/variants/Variant.java:
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contr
rdblue commented on code in PR #12374:
URL: https://github.com/apache/iceberg/pull/12374#discussion_r1966107634
##
api/src/main/java/org/apache/iceberg/variants/Serialized.java:
##
@@ -18,11 +18,8 @@
*/
package org.apache.iceberg.variants;
-/** A variant metadata and value
rdblue opened a new pull request, #12374:
URL: https://github.com/apache/iceberg/pull/12374
This has been part of other PRs, but because the `Serialized*` classes are
moving it is getting big enough to be a separate PR.
This moves the Variant interfaces from core to API and also moves
