rdblue commented on code in PR #12374:
URL: https://github.com/apache/iceberg/pull/12374#discussion_r1966110815
##########
api/src/main/java/org/apache/iceberg/variants/SerializedMetadata.java:
##########
@@ -23,15 +23,16 @@
import
org.apache.iceberg.relocated.com.google.common.annotations.VisibleForTesting;
import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
-class SerializedMetadata implements VariantMetadata, Variants.Serialized {
+class SerializedMetadata implements VariantMetadata, Serialized {
+ private static final int HEADER_SIZE = 1;
private static final int SUPPORTED_VERSION = 1;
private static final int VERSION_MASK = 0b1111;
private static final int SORTED_STRINGS = 0b10000;
private static final int OFFSET_SIZE_MASK = 0b11000000;
private static final int OFFSET_SIZE_SHIFT = 6;
static final ByteBuffer EMPTY_V1_BUFFER =
- ByteBuffer.wrap(new byte[] {0x01, 0x00}).order(ByteOrder.LITTLE_ENDIAN);
+ ByteBuffer.wrap(new byte[] {0x01, 0x00,
0x00}).order(ByteOrder.LITTLE_ENDIAN);
Review Comment:
This implementation now finds the end of the Variant metadata buffer so that
metadata and value buffers can be concatenated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
