aihuaxu commented on code in PR #12374:
URL: https://github.com/apache/iceberg/pull/12374#discussion_r1966134331


##########
api/src/test/java/org/apache/iceberg/variants/TestSerializedMetadata.java:
##########
@@ -44,7 +44,7 @@ public void testEmptyVariantMetadata() {
 
   @Test
   public void testHeaderSorted() {
-    SerializedMetadata metadata = SerializedMetadata.from(new byte[] {0b10001, 
0x00});
+    SerializedMetadata metadata = SerializedMetadata.from(new byte[] {0b10001, 
0x00, 0x00});

Review Comment:
   Later we probably need test helper function to create such byte arrays from 
strings.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to