rdblue commented on code in PR #12374:
URL: https://github.com/apache/iceberg/pull/12374#discussion_r1966111525


##########
api/src/main/java/org/apache/iceberg/variants/VariantValue.java:
##########
@@ -59,4 +59,21 @@ default VariantObject asObject() {
   default VariantArray asArray() {
     throw new IllegalArgumentException("Not an array: " + this);
   }
+
+  static VariantValue from(VariantMetadata metadata, ByteBuffer value) {

Review Comment:
   Factory methods are copied into better places in the API now, rather than 
all being in `Variants`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to