Fokko merged PR #1770:
URL: https://github.com/apache/iceberg-python/pull/1770
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceber
Fokko commented on PR #1770:
URL: https://github.com/apache/iceberg-python/pull/1770#issuecomment-2825423274
@kevinjqliu I did commit, but didn't push them 😀 Thanks for the reminder!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
kevinjqliu commented on PR #1770:
URL: https://github.com/apache/iceberg-python/pull/1770#issuecomment-2824673925
did you push the new commits? @Fokko
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
Fokko commented on code in PR #1770:
URL: https://github.com/apache/iceberg-python/pull/1770#discussion_r2054709196
##
tests/integration/test_rest_schema.py:
##
@@ -1091,16 +1095,94 @@ def test_add_required_column(catalog: Catalog) -> None:
)
+@pytest.mark.integration
+
Fokko commented on code in PR #1770:
URL: https://github.com/apache/iceberg-python/pull/1770#discussion_r2054662367
##
tests/integration/test_rest_schema.py:
##
@@ -1091,16 +1095,94 @@ def test_add_required_column(catalog: Catalog) -> None:
)
+@pytest.mark.integration
+
Fokko commented on code in PR #1770:
URL: https://github.com/apache/iceberg-python/pull/1770#discussion_r2054660974
##
pyiceberg/avro/resolver.py:
##
@@ -290,7 +290,7 @@ def struct(self, file_schema: StructType, record_struct:
Optional[IcebergType],
# There is
Fokko commented on code in PR #1770:
URL: https://github.com/apache/iceberg-python/pull/1770#discussion_r2054659488
##
pyiceberg/conversions.py:
##
@@ -540,20 +560,26 @@ def _(_: StringType, val: str) -> str:
@from_json.register(FixedType)
-def _(t: FixedType, val: str) ->
amogh-jahagirdar commented on PR #1770:
URL: https://github.com/apache/iceberg-python/pull/1770#issuecomment-2821418628
> What happens when a V2 table adds initial-default or write-default?
@kevinjqliu IMO the API would just set internally set these as `None`, and
when they're attempt
amogh-jahagirdar commented on code in PR #1770:
URL: https://github.com/apache/iceberg-python/pull/1770#discussion_r2054153800
##
tests/integration/test_rest_schema.py:
##
@@ -1091,16 +1095,94 @@ def test_add_required_column(catalog: Catalog) -> None:
)
+@pytest.mark.in
kevinjqliu commented on code in PR #1770:
URL: https://github.com/apache/iceberg-python/pull/1770#discussion_r2051534898
##
pyiceberg/conversions.py:
##
@@ -540,20 +560,26 @@ def _(_: StringType, val: str) -> str:
@from_json.register(FixedType)
-def _(t: FixedType, val: str
Fokko commented on PR #1770:
URL: https://github.com/apache/iceberg-python/pull/1770#issuecomment-2813873855
@sungwy I've included setting the default value in this PR in
`set_default_value`. PTAL :)
--
This is an automated message from the Apache Git Service.
To respond to the message, p
sungwy commented on PR #1770:
URL: https://github.com/apache/iceberg-python/pull/1770#issuecomment-2726991644
@Fokko the PR looks good to me: I think we may just have missed including
the new properties in the `rename_column` method. I agree that we could
introduce the ability to update `wr
sungwy commented on code in PR #1770:
URL: https://github.com/apache/iceberg-python/pull/1770#discussion_r1997301238
##
pyiceberg/table/update/schema.py:
##
@@ -212,13 +215,34 @@ def add_column(
# assign new IDs in order
new_id = self.assign_new_column_id()
+
malhotrashivam commented on code in PR #1770:
URL: https://github.com/apache/iceberg-python/pull/1770#discussion_r1991462871
##
pyiceberg/table/update/schema.py:
##
@@ -338,6 +363,7 @@ def _set_column_requirement(self, path: Union[str,
Tuple[str, ...]], required: b
malhotrashivam commented on code in PR #1770:
URL: https://github.com/apache/iceberg-python/pull/1770#discussion_r1989951348
##
pyiceberg/table/update/schema.py:
##
@@ -414,6 +416,7 @@ def update_column(
doc=doc if doc is not None else updated.doc,
Fokko commented on code in PR #1770:
URL: https://github.com/apache/iceberg-python/pull/1770#discussion_r1989963103
##
pyiceberg/table/update/schema.py:
##
@@ -338,6 +363,7 @@ def _set_column_requirement(self, path: Union[str,
Tuple[str, ...]], required: b
fiel
malhotrashivam commented on code in PR #1770:
URL: https://github.com/apache/iceberg-python/pull/1770#discussion_r1989951348
##
pyiceberg/table/update/schema.py:
##
@@ -414,6 +416,7 @@ def update_column(
doc=doc if doc is not None else updated.doc,
Fokko commented on code in PR #1770:
URL: https://github.com/apache/iceberg-python/pull/1770#discussion_r1989938216
##
pyiceberg/table/update/schema.py:
##
@@ -212,13 +215,34 @@ def add_column(
# assign new IDs in order
new_id = self.assign_new_column_id()
+
malhotrashivam commented on code in PR #1770:
URL: https://github.com/apache/iceberg-python/pull/1770#discussion_r1989921471
##
pyiceberg/table/update/schema.py:
##
@@ -338,6 +363,7 @@ def _set_column_requirement(self, path: Union[str,
Tuple[str, ...]], required: b
Fokko opened a new pull request, #1770:
URL: https://github.com/apache/iceberg-python/pull/1770
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
20 matches
Mail list logo
