malhotrashivam commented on code in PR #1770:
URL: https://github.com/apache/iceberg-python/pull/1770#discussion_r1991462871
##
pyiceberg/table/update/schema.py:
##
@@ -338,6 +363,7 @@ def _set_column_requirement(self, path: Union[str,
Tuple[str, ...]], required: b
malhotrashivam commented on code in PR #1770:
URL: https://github.com/apache/iceberg-python/pull/1770#discussion_r1989951348
##
pyiceberg/table/update/schema.py:
##
@@ -414,6 +416,7 @@ def update_column(
doc=doc if doc is not None else updated.doc,
Fokko commented on code in PR #1770:
URL: https://github.com/apache/iceberg-python/pull/1770#discussion_r1989963103
##
pyiceberg/table/update/schema.py:
##
@@ -338,6 +363,7 @@ def _set_column_requirement(self, path: Union[str,
Tuple[str, ...]], required: b
fiel
malhotrashivam commented on code in PR #1770:
URL: https://github.com/apache/iceberg-python/pull/1770#discussion_r1989951348
##
pyiceberg/table/update/schema.py:
##
@@ -414,6 +416,7 @@ def update_column(
doc=doc if doc is not None else updated.doc,
Fokko commented on code in PR #1770:
URL: https://github.com/apache/iceberg-python/pull/1770#discussion_r1989938216
##
pyiceberg/table/update/schema.py:
##
@@ -212,13 +215,34 @@ def add_column(
# assign new IDs in order
new_id = self.assign_new_column_id()
+
malhotrashivam commented on code in PR #1770:
URL: https://github.com/apache/iceberg-python/pull/1770#discussion_r1989921471
##
pyiceberg/table/update/schema.py:
##
@@ -338,6 +363,7 @@ def _set_column_requirement(self, path: Union[str,
Tuple[str, ...]], required: b
Fokko opened a new pull request, #1770:
URL: https://github.com/apache/iceberg-python/pull/1770
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
