Fokko commented on code in PR #1770:
URL: https://github.com/apache/iceberg-python/pull/1770#discussion_r2054660974
##########
pyiceberg/avro/resolver.py:
##########
@@ -290,7 +290,7 @@ def struct(self, file_schema: StructType, record_struct:
Optional[IcebergType],
# There is a default value
if file_field.write_default is not None:
# The field is not in the record, but there is a write
default value
- results.append((None, DefaultWriter(writer=writer,
value=file_field.write_default))) # type: ignore
+ results.append((None, DefaultWriter(writer=writer,
value=file_field.write_default)))
elif file_field.required:
Review Comment:
That's this PR https://github.com/apache/iceberg-python/pull/1644 but I
thought splitting out the schema-update changes in a separate PR might make it
easier to review 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
