malhotrashivam commented on code in PR #1770:
URL: https://github.com/apache/iceberg-python/pull/1770#discussion_r1991462871


##########
pyiceberg/table/update/schema.py:
##########
@@ -338,6 +363,7 @@ def _set_column_requirement(self, path: Union[str, 
Tuple[str, ...]], required: b
                 field_type=field.field_type,
                 doc=field.doc,
                 required=required,
+                initial_default=field.initial_default,
             )
 
     def update_column(

Review Comment:
   I am okay with either approach. If we defer it for a different PR, maybe we 
can open a follow up issue? 
   I am not too familiar with the conventions for this project.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to