malhotrashivam commented on code in PR #1770:
URL: https://github.com/apache/iceberg-python/pull/1770#discussion_r1989951348


##########
pyiceberg/table/update/schema.py:
##########
@@ -414,6 +416,7 @@ def update_column(
                 doc=doc if doc is not None else updated.doc,
                 required=updated.required,
                 initial_default=updated.initial_default,
+                write_default=updated.write_default,

Review Comment:
   Should we also take write-default as a parameter to this method, so that 
users can update the default values?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to