Re: [PR] SQL Catalog [iceberg-rust]

callum-ryan closed pull request #503: SQL Catalog URL: https://github.com/apache/iceberg-rust/pull/503 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: i

Re: [PR] SQL Catalog [iceberg-rust]

Xuanwo commented on PR #503: URL: https://github.com/apache/iceberg-rust/pull/503#issuecomment-2268443288 Hi @callum-ryan, I believe the entire SQL Catalog is quite a large project. Although @JanKaul and you have put in a lot of effort, there are still many areas that need improvement befor

Re: [PR] SQL Catalog [iceberg-rust]

Xuanwo commented on code in PR #503: URL: https://github.com/apache/iceberg-rust/pull/503#discussion_r1702853428 ## crates/catalog/sql/src/catalog.rs: ## @@ -0,0 +1,2111 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

Re: [PR] SQL Catalog [iceberg-rust]

Xuanwo commented on code in PR #503: URL: https://github.com/apache/iceberg-rust/pull/503#discussion_r1702852669 ## crates/catalog/sql/src/catalog.rs: ## @@ -0,0 +1,2111 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

Re: [PR] SQL Catalog [iceberg-rust]

fqaiser94 commented on PR #503: URL: https://github.com/apache/iceberg-rust/pull/503#issuecomment-2267084086 > Hi @fqaiser94, do you think it would be a good idea to create a new crate named `catalog_integration_tests` for those tests, so that all catalogs can use them? I imagine that each

Re: [PR] SQL Catalog [iceberg-rust]

Xuanwo commented on PR #503: URL: https://github.com/apache/iceberg-rust/pull/503#issuecomment-2267076323 > I recommend you accept each of these suggestions blindly (just click on the `Commit suggestion` button next to each one). > These suggestions add ~1500 lines of code defining 59 tes

Re: [PR] SQL Catalog [iceberg-rust]

callum-ryan commented on PR #503: URL: https://github.com/apache/iceberg-rust/pull/503#issuecomment-2266670947 > Hi @callum-ryan 👋 > > I can help with reviewing this PR since I recently completed the [Memory Catalog](https://github.com/apache/iceberg-rust/pull/475) implementation for

Re: [PR] SQL Catalog [iceberg-rust]

fqaiser94 commented on code in PR #503: URL: https://github.com/apache/iceberg-rust/pull/503#discussion_r1702429450 ## crates/catalog/sql/Cargo.toml: ## @@ -0,0 +1,48 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

Re: [PR] SQL Catalog [iceberg-rust]

sdd commented on code in PR #503: URL: https://github.com/apache/iceberg-rust/pull/503#discussion_r1699208009 ## crates/catalog/sql/src/catalog.rs: ## @@ -0,0 +1,842 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. Se

Re: [PR] SQL Catalog [iceberg-rust]

sdd commented on code in PR #503: URL: https://github.com/apache/iceberg-rust/pull/503#discussion_r1699208009 ## crates/catalog/sql/src/catalog.rs: ## @@ -0,0 +1,842 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. Se

Re: [PR] SQL Catalog [iceberg-rust]

callum-ryan commented on code in PR #503: URL: https://github.com/apache/iceberg-rust/pull/503#discussion_r1698860073 ## crates/catalog/sql/src/catalog.rs: ## @@ -0,0 +1,836 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreeme

Re: [PR] SQL Catalog [iceberg-rust]

callum-ryan commented on code in PR #503: URL: https://github.com/apache/iceberg-rust/pull/503#discussion_r1698859503 ## crates/catalog/sql/src/catalog.rs: ## @@ -0,0 +1,836 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreeme

Re: [PR] SQL Catalog [iceberg-rust]

sdd commented on code in PR #503: URL: https://github.com/apache/iceberg-rust/pull/503#discussion_r1697470138 ## crates/catalog/sql/src/catalog.rs: ## @@ -0,0 +1,836 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. Se

Re: [PR] Sql catalog [iceberg-rust]

JanKaul closed pull request #229: Sql catalog URL: https://github.com/apache/iceberg-rust/pull/229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issue

[PR] SQL Catalog [iceberg-rust]

callum-ryan opened a new pull request, #503: URL: https://github.com/apache/iceberg-rust/pull/503 This is an add-on from @JanKaul's work in a previous PR - we have spoken on slack and he is happy for me to open this PR. -- This is an automated message from the Apache Git Service. To respo

Re: [PR] Sql catalog [iceberg-rust]

JanKaul commented on code in PR #229: URL: https://github.com/apache/iceberg-rust/pull/229#discussion_r1581470280 ## crates/catalog/sql/src/catalog.rs: ## @@ -0,0 +1,517 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

Re: [PR] Sql catalog [iceberg-rust]

liurenjie1024 commented on code in PR #229: URL: https://github.com/apache/iceberg-rust/pull/229#discussion_r1579259139 ## crates/catalog/sql/Cargo.toml: ## @@ -0,0 +1,53 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

Re: [PR] Sql catalog [iceberg-rust]

JanKaul commented on PR #229: URL: https://github.com/apache/iceberg-rust/pull/229#issuecomment-2076689179 Thank you all for your helpful comments. I think the PR is ready for review again. @liurenjie1024 @sdd @odysa @ZENOTME @martin-g -- This is an automated message from the Apac

Re: [PR] Sql catalog [iceberg-rust]

liurenjie1024 commented on PR #229: URL: https://github.com/apache/iceberg-rust/pull/229#issuecomment-2076286522 > @JanKaul WDYT? I think this PR is ready for review, I can add the update and delete in a separate PR. Cool, I'll take a look first. -- This is an automated message fro

Re: [PR] Sql catalog [iceberg-rust]

himadripal commented on PR #229: URL: https://github.com/apache/iceberg-rust/pull/229#issuecomment-2062991628 @JanKaul WDYT? I think this PR is ready for review, I can add the update and delete in a separate PR. -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] Sql catalog [iceberg-rust]

JanKaul commented on PR #229: URL: https://github.com/apache/iceberg-rust/pull/229#issuecomment-2060377330 I have to add a couple of more changes. I'll notify you when I'm finished. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] Sql catalog [iceberg-rust]

liurenjie1024 commented on PR #229: URL: https://github.com/apache/iceberg-rust/pull/229#issuecomment-2059212759 cc @JanKaul Is this pr ready for review or you need to do more updates? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Sql catalog [iceberg-rust]

liurenjie1024 commented on code in PR #229: URL: https://github.com/apache/iceberg-rust/pull/229#discussion_r1522752571 ## crates/catalog/sql/src/catalog.rs: ## @@ -0,0 +1,397 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agree

Re: [PR] Sql catalog [iceberg-rust]

JanKaul commented on code in PR #229: URL: https://github.com/apache/iceberg-rust/pull/229#discussion_r1522705902 ## crates/catalog/sql/src/catalog.rs: ## @@ -0,0 +1,397 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

Re: [PR] Sql catalog [iceberg-rust]

JanKaul commented on code in PR #229: URL: https://github.com/apache/iceberg-rust/pull/229#discussion_r1521544992 ## crates/catalog/sql/src/catalog.rs: ## @@ -0,0 +1,397 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

Re: [PR] Sql catalog [iceberg-rust]

Xuanwo commented on code in PR #229: URL: https://github.com/apache/iceberg-rust/pull/229#discussion_r1519485352 ## crates/catalog/sql/src/catalog.rs: ## @@ -0,0 +1,397 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

Re: [PR] Sql catalog [iceberg-rust]

Xuanwo commented on code in PR #229: URL: https://github.com/apache/iceberg-rust/pull/229#discussion_r1519485352 ## crates/catalog/sql/src/catalog.rs: ## @@ -0,0 +1,397 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

Re: [PR] Sql catalog [iceberg-rust]

Xuanwo commented on code in PR #229: URL: https://github.com/apache/iceberg-rust/pull/229#discussion_r1519484516 ## crates/catalog/sql/Cargo.toml: ## @@ -0,0 +1,52 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See th

Re: [PR] Sql catalog [iceberg-rust]

liurenjie1024 commented on code in PR #229: URL: https://github.com/apache/iceberg-rust/pull/229#discussion_r1513742759 ## crates/catalog/sql/src/lib.rs: ## @@ -0,0 +1,24 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements

Re: [PR] Sql catalog [iceberg-rust]

odysa commented on code in PR #229: URL: https://github.com/apache/iceberg-rust/pull/229#discussion_r1513340583 ## crates/catalog/sql/src/catalog.rs: ## @@ -0,0 +1,397 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

Re: [PR] Sql catalog [iceberg-rust]

martin-g commented on code in PR #229: URL: https://github.com/apache/iceberg-rust/pull/229#discussion_r1513532822 ## crates/catalog/sql/src/error.rs: ## @@ -0,0 +1,27 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

Re: [PR] Sql catalog [iceberg-rust]

martin-g commented on code in PR #229: URL: https://github.com/apache/iceberg-rust/pull/229#discussion_r1513531369 ## crates/catalog/sql/src/catalog.rs: ## @@ -0,0 +1,397 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements

Re: [PR] Sql catalog [iceberg-rust]

martin-g commented on code in PR #229: URL: https://github.com/apache/iceberg-rust/pull/229#discussion_r1513530747 ## crates/catalog/sql/src/catalog.rs: ## @@ -0,0 +1,397 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements

Re: [PR] Sql catalog [iceberg-rust]

sdd commented on code in PR #229: URL: https://github.com/apache/iceberg-rust/pull/229#discussion_r1513373458 ## crates/catalog/sql/src/catalog.rs: ## @@ -0,0 +1,397 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. Se

Re: [PR] Sql catalog [iceberg-rust]

JanKaul commented on code in PR #229: URL: https://github.com/apache/iceberg-rust/pull/229#discussion_r1512480060 ## crates/catalog/sql/src/catalog.rs: ## @@ -0,0 +1,397 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

Re: [PR] Sql catalog [iceberg-rust]

JanKaul commented on code in PR #229: URL: https://github.com/apache/iceberg-rust/pull/229#discussion_r1512475020 ## crates/catalog/sql/src/catalog.rs: ## @@ -0,0 +1,397 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

Re: [PR] Sql catalog [iceberg-rust]

JanKaul commented on code in PR #229: URL: https://github.com/apache/iceberg-rust/pull/229#discussion_r1512473831 ## crates/catalog/sql/Cargo.toml: ## @@ -0,0 +1,52 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See t

Re: [PR] Sql catalog [iceberg-rust]

sdd commented on code in PR #229: URL: https://github.com/apache/iceberg-rust/pull/229#discussion_r1512266440 ## crates/catalog/sql/src/catalog.rs: ## @@ -0,0 +1,397 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. Se

Re: [PR] Sql catalog [iceberg-rust]

sdd commented on code in PR #229: URL: https://github.com/apache/iceberg-rust/pull/229#discussion_r1512249728 ## crates/catalog/sql/src/catalog.rs: ## @@ -0,0 +1,397 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. Se

Re: [PR] Sql catalog [iceberg-rust]

sdd commented on code in PR #229: URL: https://github.com/apache/iceberg-rust/pull/229#discussion_r1512233865 ## crates/catalog/sql/Cargo.toml: ## @@ -0,0 +1,52 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the N

Re: [PR] Sql catalog [iceberg-rust]

JanKaul commented on PR #229: URL: https://github.com/apache/iceberg-rust/pull/229#issuecomment-1977013448 PTAL @liurenjie1024 @Xuanwo @ZENOTME @Fokko -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g